Re: [PATCHES] Headers dependencies cleanup

2008-04-07 Thread Zdenek Kotala
Bruce Momjian napsal(a): Zdenek Kotala wrote: Tom Lane napsal(a): Zdenek Kotala [EMAIL PROTECTED] writes: During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some

Re: [PATCHES] Headers dependencies cleanup

2008-04-07 Thread Zdenek Kotala
Bruce Momjian napsal(a): Zdenek Kotala wrote: Tom Lane napsal(a): Zdenek Kotala [EMAIL PROTECTED] writes: During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some

Re: [PATCHES] Headers dependencies cleanup

2008-04-07 Thread Zdenek Kotala
Tom Lane napsal(a): Bruce Momjian [EMAIL PROTECTED] writes: Zdenek Kotala wrote: bufpage.h includes bufmgr.h, but bufpage.h does not require any definition from bufmgr.h. I think this dependency is there for long time. My scripts should have found this issue, see

Re: [PATCHES] Headers dependencies cleanup

2008-04-07 Thread Alvaro Herrera
Zdenek Kotala wrote: PS: Is there any reason to do not start to use inline functions instead of macros in some cases? Not all compilers like (== support) inline macros apparently. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command

Re: [PATCHES] Headers dependencies cleanup

2008-04-07 Thread Alvaro Herrera
Zdenek Kotala wrote: Alvaro Herrera napsal(a): Zdenek Kotala wrote: PS: Is there any reason to do not start to use inline functions instead of macros in some cases? Not all compilers like (== support) inline macros apparently. Is it your assumption or do you mean some specific compiler?

Re: [PATCHES] Headers dependencies cleanup

2008-04-07 Thread Andrew Dunstan
Zdenek Kotala wrote: Is it your assumption or do you mean some specific compiler? IIRC, inline is defined in C99 and my assumption :-) is that it should be supported by all compilers today. I try to look on buildmachine, There should be some useful configure output. My recollection is

Re: [PATCHES] Headers dependencies cleanup

2008-04-07 Thread Zdenek Kotala
Alvaro Herrera napsal(a): Zdenek Kotala wrote: PS: Is there any reason to do not start to use inline functions instead of macros in some cases? Not all compilers like (== support) inline macros apparently. Is it your assumption or do you mean some specific compiler? IIRC, inline is

Re: [PATCHES] Headers dependencies cleanup

2008-04-07 Thread Tom Lane
Zdenek Kotala [EMAIL PROTECTED] writes: Alvaro Herrera napsal(a): Not all compilers like (== support) inline macros apparently. Is it your assumption or do you mean some specific compiler? IIRC, inline is defined in C99 and my assumption :-) is that it should be supported by all compilers

Re: [PATCHES] Headers dependencies cleanup

2008-04-05 Thread Bruce Momjian
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: Zdenek Kotala wrote: During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some other headers file.

Re: [PATCHES] Headers dependencies cleanup

2008-04-05 Thread Bruce Momjian
Zdenek Kotala wrote: Tom Lane napsal(a): Zdenek Kotala [EMAIL PROTECTED] writes: During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some other headers file.

Re: [PATCHES] Headers dependencies cleanup

2008-04-05 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Zdenek Kotala wrote: bufpage.h includes bufmgr.h, but bufpage.h does not require any definition from bufmgr.h. I think this dependency is there for long time. My scripts should have found this issue, see src/tools/pginclude/pgrminclude. Looking

Re: [PATCHES] Headers dependencies cleanup

2008-04-05 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: I run it every few years rather than every year because it can break stuff that we have to manually fix by adding includes. If you want it run now or every year, let me know. I'm not in a hurry --- as we found out last time, that script isn't really

Re: [PATCHES] Headers dependencies cleanup

2008-04-05 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: I run it every few years rather than every year because it can break stuff that we have to manually fix by adding includes. If you want it run now or every year, let me know. I'm not in a hurry --- as we found out last time, that

Re: [PATCHES] Headers dependencies cleanup

2008-04-04 Thread Alvaro Herrera
Zdenek Kotala wrote: During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some other headers file. This patch fixes these dependencies around bufpage.h, bufmgr.h

Re: [PATCHES] Headers dependencies cleanup

2008-04-04 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: Zdenek Kotala wrote: During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some other headers file. This patch fixes these

Re: [PATCHES] Headers dependencies cleanup

2008-04-04 Thread Zdenek Kotala
Alvaro Herrera napsal(a): Zdenek Kotala wrote: During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some other headers file. This patch fixes these dependencies around

Re: [PATCHES] Headers dependencies cleanup

2008-04-04 Thread Zdenek Kotala
Tom Lane napsal(a): Alvaro Herrera [EMAIL PROTECTED] writes: Zdenek Kotala wrote: During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some other headers file. This

Re: [PATCHES] Headers dependencies cleanup

2008-04-04 Thread Tom Lane
Zdenek Kotala [EMAIL PROTECTED] writes: During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some other headers file. Bruce periodically runs a script that's

Re: [PATCHES] Headers dependencies cleanup

2008-04-04 Thread Zdenek Kotala
Tom Lane napsal(a): Zdenek Kotala [EMAIL PROTECTED] writes: During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some other headers file. Bruce periodically runs a

[PATCHES] Headers dependencies cleanup

2007-10-25 Thread Zdenek Kotala
During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some other headers file. This patch fixes these dependencies around bufpage.h, bufmgr.h