Re: [PATCHES] Lazy xid assignment V3

2007-09-03 Thread Tom Lane
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > Yeah. If we did want to do something more, we could acquire the lock on > vid conditionally, and use another vid if acquiring the lock fails. But > I don't think it's necessary. I was thinking more along the lines of looking through the ProcArray

Re: [PATCHES] Lazy xid assignment V3

2007-09-03 Thread Florian G. Pflug
Heikki Linnakangas wrote: Tom Lane wrote: "Florian G. Pflug" <[EMAIL PROTECTED]> writes: Tom Lane wrote: "Heikki Linnakangas" <[EMAIL PROTECTED]> writes: Should there be new a log_line_prefix percent code for virtual transaction ids? Or should we change the meaning of %x to be virtual transac

Re: [PATCHES] Lazy xid assignment V3

2007-09-03 Thread Heikki Linnakangas
Tom Lane wrote: > "Florian G. Pflug" <[EMAIL PROTECTED]> writes: >> Tom Lane wrote: >>> "Heikki Linnakangas" <[EMAIL PROTECTED]> writes: Should there be new a log_line_prefix percent code for virtual transaction ids? Or should we change the meaning of %x to be virtual transaction id

Re: [PATCHES] Lazy xid assignment V3

2007-09-03 Thread Florian G. Pflug
Tom Lane wrote: "Florian G. Pflug" <[EMAIL PROTECTED]> writes: Tom Lane wrote: "Heikki Linnakangas" <[EMAIL PROTECTED]> writes: Should there be new a log_line_prefix percent code for virtual transaction ids? Or should we change the meaning of %x to be virtual transaction id instead of the real

Re: [PATCHES] Lazy xid assignment V3

2007-09-03 Thread Tom Lane
"Florian G. Pflug" <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> "Heikki Linnakangas" <[EMAIL PROTECTED]> writes: >>> Should there be new a log_line_prefix percent code for virtual >>> transaction ids? Or should we change the meaning of %x to be virtual >>> transaction id instead of the real one

Re: [PATCHES] Lazy xid assignment V3

2007-09-03 Thread Florian G. Pflug
Tom Lane wrote: "Heikki Linnakangas" <[EMAIL PROTECTED]> writes: Should there be new a log_line_prefix percent code for virtual transaction ids? Or should we change the meaning of %x to be virtual transaction id instead of the real one. I think the latter should be sufficient, especially if we

Re: [PATCHES] Lazy xid assignment V3

2007-09-03 Thread Tom Lane
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > Should there be new a log_line_prefix percent code for virtual > transaction ids? Or should we change the meaning of %x to be virtual > transaction id instead of the real one. I think the latter should be sufficient, especially if we also are show

Re: [PATCHES] Lazy xid assignment V3

2007-09-03 Thread Marko Kreen
On 9/3/07, Alvaro Herrera <[EMAIL PROTECTED]> wrote: > Marko Kreen escribió: > > On 9/3/07, Alvaro Herrera <[EMAIL PROTECTED]> wrote: > > > Florian G. Pflug wrote: > > > > Since we didn't really reach an agreement on how xid_age should behave, > > > > I've reverted it back to the original version.

Re: [PATCHES] Lazy xid assignment V3

2007-09-03 Thread Alvaro Herrera
Marko Kreen escribió: > On 9/3/07, Alvaro Herrera <[EMAIL PROTECTED]> wrote: > > Florian G. Pflug wrote: > > > Since we didn't really reach an agreement on how xid_age should behave, > > > I've reverted it back to the original version. So with this patch, > > > xid_age will just force assignment of

Re: [PATCHES] Lazy xid assignment V3

2007-09-03 Thread Heikki Linnakangas
Florian G. Pflug wrote: > Here is an updated version of my patch. This is pretty much equivalent > to the version V2, apart from the few minor things Tom criticized. The > changes are. Should there be new a log_line_prefix percent code for virtual transaction ids? Or should we change the meaning o

Re: [PATCHES] Lazy xid assignment V3

2007-09-03 Thread Marko Kreen
On 9/3/07, Alvaro Herrera <[EMAIL PROTECTED]> wrote: > Florian G. Pflug wrote: > > Since we didn't really reach an agreement on how xid_age should behave, > > I've reverted it back to the original version. So with this patch, > > xid_age will just force assignment of a xid. > > Is this really a goo

Re: [PATCHES] Lazy xid assignment V3

2007-09-03 Thread Alvaro Herrera
Florian G. Pflug wrote: > Since we didn't really reach an agreement on how xid_age should behave, > I've reverted it back to the original version. So with this patch, > xid_age will just force assignment of a xid. Is this really a good idea? I'm repeating myself, but a query like select age(xmi

[PATCHES] Lazy xid assignment V3

2007-09-02 Thread Florian G. Pflug
I tried sending this with the actual patch attached - this time, to pgsql-pacthes, but it seems that my mail didn't get through again. So it've put up the patch here: http://soc.phlo.org/lazyxidassign.v3.patch Hi Here is an updated version of my patch. Th