Re: [PATCHES] Minor BEFORE DELETE trigger fix

2004-08-12 Thread Gavin Sherry
On Thu, 12 Aug 2004, Bruce Momjian wrote: > > Did this get resolved? > > --- > > Gavin Sherry wrote: > > Attached is a minor patch to make BEFORE DELETE triggers honour tgenabled > > properly. > > > > I know that we cannot, cu

Re: [PATCHES] Minor BEFORE DELETE trigger fix

2004-08-12 Thread Bruce Momjian
Did this get resolved? --- Gavin Sherry wrote: > Attached is a minor patch to make BEFORE DELETE triggers honour tgenabled > properly. > > I know that we cannot, currently, use this feature through a DDL command > but just

Re: [PATCHES] Minor BEFORE DELETE trigger fix

2004-08-07 Thread Tom Lane
Gavin Sherry <[EMAIL PROTECTED]> writes: > Now, if for all the triggers on the base relation, !trigger->tgenabled is > true, then newtuple will always be NULL. Hmm ... seems like the all-triggers-disabled case should act the same as the no-triggers-at-all case, which this doesn't seem to do. It d

Re: [PATCHES] Minor BEFORE DELETE trigger fix

2004-08-06 Thread Tom Lane
Gavin Sherry <[EMAIL PROTECTED]> writes: > Attached in the usual format this time. AFAICS this patch makes exactly zero change in behavior. What was the point again? Also, if there is a point, why are we changing only one of the several ExecFOOTriggers functions? regards

Re: [PATCHES] Minor BEFORE DELETE trigger fix

2004-08-06 Thread Gavin Sherry
On Sat, 7 Aug 2004, Tom Lane wrote: > Gavin Sherry <[EMAIL PROTECTED]> writes: > > Attached in the usual format this time. > > AFAICS this patch makes exactly zero change in behavior. What was > the point again? With BEFORE DELETE triggers, if the trigger returns NULL, then the DELETE will not t

Re: [PATCHES] Minor BEFORE DELETE trigger fix

2004-08-06 Thread Gavin Sherry
Oops. Attached in the usual format this time. Gavin On Fri, 6 Aug 2004, Bruce Momjian wrote: > > Can I get a context diff please? > > --- > > Gavin Sherry wrote: > > Attached is a minor patch to make BEFORE DELETE triggers

Re: [PATCHES] Minor BEFORE DELETE trigger fix

2004-08-06 Thread Bruce Momjian
Can I get a context diff please? --- Gavin Sherry wrote: > Attached is a minor patch to make BEFORE DELETE triggers honour tgenabled > properly. > > I know that we cannot, currently, use this feature through a DDL command >

[PATCHES] Minor BEFORE DELETE trigger fix

2004-08-04 Thread Gavin Sherry
Attached is a minor patch to make BEFORE DELETE triggers honour tgenabled properly. I know that we cannot, currently, use this feature through a DDL command but just in case someone is updating the catalogs to do it and since it is necessary in order to implement disabling of triggers, I thought I