Re: [update] Re: [PATCHES] Patch to bring \copy syntax more in line with SQL copy

2004-01-28 Thread Tom Lane
Bill Moran <[EMAIL PROTECTED]> writes: > As far as I can tell, this should make the \copy syntax equivalent to the > SQL copy syntax (as described in the docs) while still maintaining > backward compatibility with older syntaxes. On reviewing this, I see that the existing code is much closer to wh

[update] Re: [PATCHES] Patch to bring \copy syntax more in line with SQL copy

2004-01-25 Thread Bill Moran
Please find a pair of updated patches attached. The first is against src/bin/pgsql/copy.c It changes the acceptable syntax for \copy to allow the following: [ [with|using] delimiter[s] [as] delimiter ] Improvements over the previously posted patch: 1) c++ style comments removed. 2) Comments with

Re: [PATCHES] Patch to bring \copy syntax more in line with SQL copy

2004-01-21 Thread Tom Lane
Bill Moran <[EMAIL PROTECTED]> writes: > A revised patch will be forthcoming, as soon as I find some time ... BTW, it would be good to update to CVS HEAD before you revise the patch, as I just yesterday applied a couple of other patches in the same general area. I don't think there were any code

Re: [PATCHES] Patch to bring \copy syntax more in line with SQL copy

2004-01-21 Thread Dennis Bjorklund
On Wed, 21 Jan 2004, Peter Eisentraut wrote: > Am Mittwoch, 21. Januar 2004 02:16 schrieb Bill Moran: > > BTW: Why is this frowned apon so? Are there compilers that have > > problems with it? > > Yes. Search the archives for "AIX". :-) I googled a little for the aix compiler and it looks like

Re: [PATCHES] Patch to bring \copy syntax more in line with SQL copy

2004-01-21 Thread Peter Eisentraut
Am Mittwoch, 21. Januar 2004 02:16 schrieb Bill Moran: > BTW: Why is this frowned apon so? Are there compilers that have > problems with it? Yes. Search the archives for "AIX". :-) ---(end of broadcast)--- TIP 3: if posting/reading through Usenet

Re: [PATCHES] Patch to bring \copy syntax more in line with SQL copy

2004-01-20 Thread Bill Moran
Neil Conway wrote: A few quick comments: - don't use C++-style comments Oops ... sorry ... been doing too much PHP. BTW: Why is this frowned apon so? Are there compilers that have problems with it? In my own code, I generally use // and /* */ interchangeably, and I've never had any problems (wi

[PATCHES] Patch to bring \copy syntax more in line with SQL copy

2004-01-17 Thread Bill Moran
This patch brings the \copy syntax of psql more in line with the SQL copy syntax as described in the reference manual, while maintaining backward compatibility with what was there prior to the patch. The change to the syntax is to the DELIMITER[S] portion. The man page for psql refers the reader t