Re: [PATCHES] Postgresql.conf, initdb patch

2003-07-02 Thread Bruce Momjian
Tom has applied your patch with edits. Thanks. --- Shridhar Daithankar wrote: > On Tuesday 01 July 2003 05:39, Peter Eisentraut wrote: > > Josh Berkus writes: > > > initdb.patch, written by Shridhar, patches initdb so that

Re: [PATCHES] Postgresql.conf, initdb patch

2003-07-01 Thread Shridhar Daithankar
On Tuesday 01 July 2003 05:39, Peter Eisentraut wrote: > Josh Berkus writes: > > initdb.patch, written by Shridhar, patches initdb so that the LC_* > > localization variables are inserted into postgresql.conf at the point > > commented "#LC VARS GO HERE!" > > It's pretty pointless to use > > cat $f

Re: [PATCHES] Postgresql.conf, initdb patch

2003-06-30 Thread Peter Eisentraut
Josh Berkus writes: > initdb.patch, written by Shridhar, patches initdb so that the LC_* > localization variables are inserted into postgresql.conf at the point > commented "#LC VARS GO HERE!" It's pretty pointless to use cat $file | sed 's/.../' because sed can open files perfectly well: sed

Re: [PATCHES] Postgresql.conf, initdb patch

2003-06-30 Thread Tom Lane
Josh Berkus <[EMAIL PROTECTED]> writes: >> Another tack is to change the section title to something more >> inclusive. Maybe "Error Reporting and Logging"? > Sounds good to me. Shall we apply the patch I just submitted, and then I'll > submit a patch for both runtime.sgml and postgresql.conf.sa

Re: [PATCHES] Postgresql.conf, initdb patch

2003-06-30 Thread Josh Berkus
Tom, > Another tack is to change the section title to something more > inclusive. Maybe "Error Reporting and Logging"? Sounds good to me. Shall we apply the patch I just submitted, and then I'll submit a patch for both runtime.sgml and postgresql.conf.sample? -- -Josh Berkus __AGLIO DAT

Re: [PATCHES] Postgresql.conf, initdb patch

2003-06-30 Thread Tom Lane
> So, I should put it under "Client Connection Defaults", then? Probably. But then you have to figure out what to do with the list of values that it shares with server_min_messages. Another tack is to change the section title to something more inclusive. Maybe "Error Reporting and Logging"?

Re: [PATCHES] Postgresql.conf, initdb patch

2003-06-30 Thread Josh Berkus
Tom, > > What is CLIENT_MIN_MESSAGES for, then? > > Controls which messages get sent to the client. So, I should put it under "Client Connection Defaults", then? -- -Josh Berkus __AGLIO DATABASE SOLUTIONS___ Josh Berkus Co

Re: [PATCHES] Postgresql.conf, initdb patch

2003-06-30 Thread Tom Lane
Josh Berkus <[EMAIL PROTECTED]> writes: > What is CLIENT_MIN_MESSAGES for, then? Controls which messages get sent to the client. regards, tom lane ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose

Re: [PATCHES] Postgresql.conf, initdb patch

2003-06-30 Thread Josh Berkus
Tom, > BTW, now that I look more closely at the new docs, there are some > classifications that seem pretty bizarre. For instance, > CLIENT_MIN_MESSAGES has nothing to do with the server log and doesn't > seem to belong in a section about logging ... Would have been nice if someone had mentioned

Re: [PATCHES] Postgresql.conf, initdb patch

2003-06-30 Thread Tom Lane
Josh Berkus <[EMAIL PROTECTED]> writes: > postgresql.conf.patch re-orders postgresql.conf.sample according to the ord= > er=20 > patched into runtime.sgml last week. I've probably already broken this patch by modifying .conf.sample :-(. Will take care of the cleanup. BTW, now that I look more clo

[PATCHES] Postgresql.conf, initdb patch

2003-06-30 Thread Josh Berkus
Folks, Attached are 2 patches: postgresql.conf.patch re-orders postgresql.conf.sample according to the order patched into runtime.sgml last week. initdb.patch, written by Shridhar, patches initdb so that the LC_* localization variables are inserted into postgresql.conf at the point commented