Re: [PATCHES] Problem with Create Domain example

2005-05-01 Thread Neil Conway
Robert Treat wrote: Is there any plans to back patch this into 8.0.x? Yeah, I was wondering about that -- I've backported the patch to REL8_0_STABLE. -Neil ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://arc

Re: [PATCHES] Problem with Create Domain example

2005-05-01 Thread Robert Treat
On Sunday 01 May 2005 11:58, Tom Lane wrote: > Robert Treat <[EMAIL PROTECTED]> writes: > > The example given in create domain seems to be broken. ISTM it requires > > some extra escaping to be usable (at least in my goings on today it sure > > was, and I the entries in pg_constraint sure seem to i

Re: [PATCHES] Problem with Create Domain example

2005-05-01 Thread Tom Lane
Robert Treat <[EMAIL PROTECTED]> writes: > The example given in create domain seems to be broken. ISTM it requires some > extra escaping to be usable (at least in my goings on today it sure was, and > I the entries in pg_constraint sure seem to indicate this as well). I > suggest that the examp

Re: [PATCHES] Problem with Create Domain example

2005-04-30 Thread Alvaro Herrera
On Sat, Apr 30, 2005 at 07:45:29PM -0700, David Fetter wrote: > > Not sure what your driving at here... my point is that the \ > > escaping is incorrect in the current examples. > > That was pretty much my thought. It's extremely easy to turn regexes > into unmaintainable garbage, whereas the

Re: [PATCHES] Problem with Create Domain example

2005-04-30 Thread David Fetter
On Sat, Apr 30, 2005 at 10:08:32PM -0400, Robert Treat wrote: > On Saturday 30 April 2005 21:14, Alvaro Herrera wrote: > > On Sat, Apr 30, 2005 at 06:12:27PM -0400, Robert Treat wrote: > > > --- 167,174 > > > > > > CREATE DOMAIN us_postal_code AS TEXT > > > CHECK( > > > !VALUE ~ '^\

Re: [PATCHES] Problem with Create Domain example

2005-04-30 Thread Robert Treat
On Saturday 30 April 2005 21:14, Alvaro Herrera wrote: > On Sat, Apr 30, 2005 at 06:12:27PM -0400, Robert Treat wrote: > > --- 167,174 > > > > CREATE DOMAIN us_postal_code AS TEXT > > CHECK( > > !VALUE ~ '^\\d{5}$' > > ! OR VALUE ~ '^\\d{5}-\\d{4}$' > > ); > > Huh, why not > > VAL

Re: [PATCHES] Problem with Create Domain example

2005-04-30 Thread Alvaro Herrera
On Sat, Apr 30, 2005 at 06:12:27PM -0400, Robert Treat wrote: > --- 167,174 > > CREATE DOMAIN us_postal_code AS TEXT > CHECK( > !VALUE ~ '^\\d{5}$' > ! OR VALUE ~ '^\\d{5}-\\d{4}$' > ); Huh, why not VALUE ~ '^\\d{5}(-\\d{4})?$' ? -- Alvaro Herrera (<[EMAIL PROTECTED]>) "Cuan

[PATCHES] Problem with Create Domain example

2005-04-30 Thread Robert Treat
The example given in create domain seems to be broken. ISTM it requires some extra escaping to be usable (at least in my goings on today it sure was, and I the entries in pg_constraint sure seem to indicate this as well). I suggest that the examples should be updated as per the following patch.