Re: [PATCHES] Re [HACKERS]: Still not happy with psql's multiline history behavior

2006-06-07 Thread Bruce Momjian
Conditional history length test removed. --- Bruce Momjian wrote: > > Also, in this line from psql/mainloop.c: > > 312 if (scan_result == PSCAN_BACKSLASH && history_buf->len != 0) > > Is the "history_buf->len !=

Re: [PATCHES] Re [HACKERS]: Still not happy with psql's multiline history behavior

2006-06-04 Thread Bruce Momjian
Also, in this line from psql/mainloop.c: 312 if (scan_result == PSCAN_BACKSLASH && history_buf->len != 0) Is the "history_buf->len != 0" test necessary? --- pgman wrote: > Sergey E. Koposov wrote: > > On Sun, 4 J

Re: [PATCHES] Re [HACKERS]: Still not happy with psql's multiline history behavior

2006-06-04 Thread Bruce Momjian
Sergey E. Koposov wrote: > On Sun, 4 Jun 2006, Bruce Momjian wrote: > > > Sergey E. Koposov wrote: > >> Hello, > >> > >> I'm sending the patch fixing the \r bug: > > > > Funny, I just applied a simpler fix for the \r bug. Please review it. > > Thanks. > > > > It is simpler, because it behaves di

[PATCHES] Re [HACKERS]: Still not happy with psql's multiline history behavior

2006-06-03 Thread Sergey E. Koposov
Hello, I'm sending the patch fixing the \r bug: On Wed, 31 May 2006, Tom Lane wrote: The example that seriously sucks is: regression=# select foo ... regression-# \r Query buffer reset (cleared). now control-P brings back: regression=# select foo ... \r In my fix the currently-written query

Re: [PATCHES] Re [HACKERS]: Still not happy with psql's multiline history behavior

2006-06-03 Thread Bruce Momjian
Sergey E. Koposov wrote: > Hello, > > I'm sending the patch fixing the \r bug: Funny, I just applied a simpler fix for the \r bug. Please review it. Thanks. I am confused by the \e bug. I just tried 8.1.X and it seems to behave the same as CVS HEAD. What exactly should it do? --