Re: [PATCHES] ReadBuffer() error checking

2004-11-13 Thread Neil Conway
Tom Lane wrote: Agreed. I get the impression that at one time it was not so, but certainly for the last many years there's been no need to test. Patch applied. A related issue in the same general area is that the smgr code is currently implemented to elog on error, but its API still reflects an as

Re: [PATCHES] ReadBuffer() error checking

2004-11-13 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > AFAIK, ReadBuffer() will elog on error, so callers can assume that the > buffer it returns is valid. The vast majority of ReadBuffer() call sites > make this assumption, but some went to the trouble of checking that the > returned buffer was valid and el

[PATCHES] ReadBuffer() error checking

2004-11-13 Thread Neil Conway
AFAIK, ReadBuffer() will elog on error, so callers can assume that the buffer it returns is valid. The vast majority of ReadBuffer() call sites make this assumption, but some went to the trouble of checking that the returned buffer was valid and elog'ing if it was not. I've removed the error ch