Re: [PATCHES] Silly bug in pgbench's random number generator

2008-03-09 Thread Tom Lane
Alexey Klyukin <[EMAIL PROTECTED]> writes: > Gregory Stark wrote: >> pgbench's random number generator was only generating the first and last >> value >> in the specified range half as often as other values in the range. > I think this line should be altered this way: > return min + (int) (((max

Re: [PATCHES] Silly bug in pgbench's random number generator

2007-07-16 Thread Gregory Stark
Uhm, this is a one-line *bug fix*. "Bruce Momjian" <[EMAIL PROTECTED]> writes: > This has been saved for the 8.4 release: > > http://momjian.postgresql.org/cgi-bin/pgpatches_hold > > --- > > Gregory Stark wrote: >> >

Re: [PATCHES] Silly bug in pgbench's random number generator

2007-07-16 Thread Bruce Momjian
Gregory Stark wrote: > > Uhm, this is a one-line *bug fix*. There wasn't agreement on how it should be fixed, it is a minor bug, and as you said, we should be focusing on the significant outstanding patches submitted before feature freeze.

Re: [PATCHES] Silly bug in pgbench's random number generator

2007-07-16 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Gregory Stark wrote: > > pgbench's random number generator was only generating the first and last value > in the spe

Re: [PATCHES] Silly bug in pgbench's random number generator

2007-06-14 Thread Alexey Klyukin
Gregory Stark wrote: > > pgbench's random number generator was only generating the first and last value > in the specified range half as often as other values in the range. Not that it > actually matters but it may as well do what it claims. This line has a pretty > long and sordid history with va

[PATCHES] Silly bug in pgbench's random number generator

2007-06-14 Thread Gregory Stark
pgbench's random number generator was only generating the first and last value in the specified range half as often as other values in the range. Not that it actually matters but it may as well do what it claims. This line has a pretty long and sordid history with various people tweaking it one wa