Re: [PATCHES] Suppress compiler warnings on mingw

2008-04-16 Thread Andrew Dunstan
Applied, Thanks. wiki updated. cheers andrew ITAGAKI Takahiro wrote: Peter Eisentraut <[EMAIL PROTECTED]> wrote: Then try using %lu and no casts. That should get rid of the warnings the proper way. Ok, I rewrote it to use %lu for format strings. Jeremy Drake <[EMAIL PROTECTED

Re: [PATCHES] Suppress compiler warnings on mingw

2008-03-16 Thread ITAGAKI Takahiro
Peter Eisentraut <[EMAIL PROTECTED]> wrote: > Then try using %lu and no casts. That should get rid of the warnings the > proper way. Ok, I rewrote it to use %lu for format strings. Jeremy Drake <[EMAIL PROTECTED]> wrote: > sizeof(DWORD) is always 4, even on 64-bit windows. sizeof(long) is a

Re: [PATCHES] Suppress compiler warnings on mingw

2008-03-14 Thread Peter Eisentraut
ITAGAKI Takahiro wrote: > DWORD is an alias for 'unsigned long' in 32bit Windows. Then try using %lu and no casts. That should get rid of the warnings the proper way. -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgres

Re: [PATCHES] Suppress compiler warnings on mingw

2008-03-14 Thread Jeremy Drake
On Fri, 14 Mar 2008, ITAGAKI Takahiro wrote: > DWORD is an alias for 'unsigned long' in 32bit Windows. > Do you know how it defined in 64bit Windows? sizeof(DWORD) is always 4, even on 64-bit windows. sizeof(long) is also always 4. If you want the unsigned integral type that is the same size as

Re: [PATCHES] Suppress compiler warnings on mingw

2008-03-13 Thread ITAGAKI Takahiro
Peter Eisentraut <[EMAIL PROTECTED]> wrote: > ITAGAKI Takahiro wrote: > > - Cast DWORD to unsigned integer explicitly. > > DWORD is always 32bit integer on both 32bit and 64bit Windows. > > I think if that is so, you wouldn't need to add any casts. Instead you would > only need to use the

Re: [PATCHES] Suppress compiler warnings on mingw

2008-03-13 Thread Peter Eisentraut
ITAGAKI Takahiro wrote: > - Cast DWORD to unsigned integer explicitly. > DWORD is always 32bit integer on both 32bit and 64bit Windows. I think if that is so, you wouldn't need to add any casts. Instead you would only need to use the right format specifier. -- Sent via pgsql-patches mailin

[PATCHES] Suppress compiler warnings on mingw

2008-03-13 Thread ITAGAKI Takahiro
Here is a patch to suppress compiler warnings in mingw build. - Remove unused local variables. - Cast DWORD to unsigned integer explicitly. DWORD is always 32bit integer on both 32bit and 64bit Windows. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center mingw-warnings.patch Desc