Re: [PATCHES] WAL: O_DIRECT and multipage-writer

2005-01-25 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > I resend the patch with diff -c. What does XLOG_EXTRA_BUFFERS accomplish? Also, I'm worried that you broke something by not updating Write->curridx immediately in XLogWrite. There certainly isn't going to be any measurable performance boost from kee

Re: [PATCHES] WAL: O_DIRECT and multipage-writer

2005-01-25 Thread ITAGAKI Takahiro
Excuse me. I resend the patch with diff -c. On Tue, 25 Jan 2005 10:30:01 +0100 "Michael Paesold" <[EMAIL PROTECTED]> wrote: > ITAGAKI Takahiro wrote: > > > I think that there is room for improvement in WAL. > > Here is a patch for it. > > I think you should resend your patch as a context diff

Re: [PATCHES] WAL: O_DIRECT and multipage-writer

2005-01-25 Thread Michael Paesold
ITAGAKI Takahiro wrote: I think that there is room for improvement in WAL. Here is a patch for it. I think you should resend your patch as a context diff (diff -c). Otherwise it's hard to see what your patch does. Best Regards, Michael Paesold ---(end of broadcast)--

[PATCHES] WAL: O_DIRECT and multipage-writer

2005-01-25 Thread ITAGAKI Takahiro
Hello, all. I think that there is room for improvement in WAL. Here is a patch for it. - Multiple pages are written in one write() if it is contiguous. - Add 'open_direct' to wal_sync_method. WAL writer writes one page in one write(). This is not efficient when wal_sync_method is 'open_sync'