Re: [PATCHES] fix recent WITH OIDS bug

2004-01-22 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Yeah, I had considered that, but hesitated for the same reason you > cite. Is it worth creating a parse_util.c, perhaps? Okay with me, if you feel like taking the trouble. regards, tom lane ---(end of broad

Re: [PATCHES] fix recent WITH OIDS bug

2004-01-22 Thread Neil Conway
Tom Lane <[EMAIL PROTECTED]> writes: > You could possibly put it next to the existing function > interpretInhOption(), which does essentially the same kind of thing > and for the same reason. However, I can't argue that that > function's placement in parse_clause.c has any real strong > motivation

Re: [PATCHES] fix recent WITH OIDS bug

2004-01-22 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > The only question I have is whether analyze.c (and therefore > analyze.h) is the right place to put the new utility function > interpretOidsOption() -- can anyone suggest a better location? You could possibly put it next to the existing function interpretI

[PATCHES] fix recent WITH OIDS bug

2004-01-22 Thread Neil Conway
This patch fixes a bug I introduced in the recent CREATE TABLE AS / WITH OIDS work. The patch should be pretty straight-forward. The only question I have is whether analyze.c (and therefore analyze.h) is the right place to put the new utility function interpretOidsOption() -- can anyone suggest a