Re: [PATCHES] fix schema ownership for database owner on first

2004-06-10 Thread Fabien COELHO
Dear Bruce, On Wed, 9 Jun 2004, Bruce Momjian wrote: Would you adjust based on Tom's comments and resubmit? Thanks. Done. ! Date: Wed, 9 Jun 2004 14:31:59 +0200 (CEST) ! From: Fabien COELHO [EMAIL PROTECTED] ! To: PostgreSQL Patches [EMAIL PROTECTED] ! Subject: [PATCHES] fix schema

Re: [PATCHES] fix schema ownership for database owner on first connection

2004-06-09 Thread Bruce Momjian
Would you adjust based on Tom's comments and resubmit? Thanks. --- Fabien COELHO wrote: Dear patchers, Please find attached a patch to fix schema ownership on first connection, so that non system schemas reflect

[PATCHES] fix schema ownership for database owner on first connection

2004-06-08 Thread Fabien COELHO
Dear patchers, Please find attached a patch to fix schema ownership on first connection, so that non system schemas reflect the database owner. (1) It adds a new datisinit attribute to pg_database, which tells whether the database initialization was performed or not. The documentation is

Re: [PATCHES] fix schema ownership for database owner on first

2004-06-08 Thread Fabien COELHO
Dear Tom, (2) This boolean is tested in postinit.c:ReverifyMyDatabase, and InitializeDatabase is called if necessary. And what happens if multiple backends try to connect at the same time? I took care of that one! There is a lock on the update of pg_database when switching off datisinit. The

Re: [PATCHES] fix schema ownership for database owner on first connection

2004-06-08 Thread Tom Lane
Fabien COELHO [EMAIL PROTECTED] writes: I do not think it's a good idea for the regression tests to do anything to any databases other than regression. Especially not databases with names that might match people's real databases. Oh, you mean calvin and hobbes might use postgresql? ;-)

Re: [PATCHES] fix schema ownership for database owner on first

2004-06-08 Thread Fabien COELHO
Ok, so I guess I can use regressionuser[123], regression[123] as names in the validation. Writing tests cases is not fun, so I tried to put some fun by using these characters. I don't really think it's necessary for the regression tests to test this functionality. Hummm... an interesting view,

Re: [PATCHES] fix schema ownership for database owner on first connection

2004-06-08 Thread Christopher Kings-Lynne
Ok, so I guess I can use regressionuser[123], regression[123] as names in the validation. Writing tests cases is not fun, so I tried to put some fun by using these characters. I don't really think it's necessary for the regression tests to test this functionality. Once this machinery is in...can