Re: [PATCHES] minor nodeIndexScan tweak

2005-07-07 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Per EDB's Coverity analysis, "runtimeKeyInfo" is only non-NULL if > "econtext" is also non-NULL, so we can eliminate a conditional on the > former by moving it inside an "if" block for the latter. This is premature optimization par excellance --- it save

[PATCHES] minor nodeIndexScan tweak

2005-07-07 Thread Neil Conway
Per EDB's Coverity analysis, "runtimeKeyInfo" is only non-NULL if "econtext" is also non-NULL, so we can eliminate a conditional on the former by moving it inside an "if" block for the latter. Per discussion of earlier similar changes, this is not for performance reasons but for code clarity.