Re: [PATCHES] too many variants of relation_open

2007-09-28 Thread Heikki Linnakangas
Jaime Casanova wrote: I can understand why we have relation_openrv and try_relation_open, but relation_open_nowait can be merged with relation_open. Well, yes it could, but why? Keeping them separate looks slightly more readable to me, and the change could break a lot of external modules for no

[PATCHES] too many variants of relation_open

2007-09-28 Thread Jaime Casanova
Hi, I can understand why we have relation_openrv and try_relation_open, but relation_open_nowait can be merged with relation_open. Or there is something i'm missing? attached is a patch that do the merge. -- regards, Jaime Casanova Programming today is a race between software engineers

Re: [PATCHES] too many variants of relation_open

2007-09-28 Thread Neil Conway
On Fri, 2007-09-28 at 10:02 +0100, Heikki Linnakangas wrote: Well, yes it could, but why? Keeping them separate looks slightly more readable to me, and the change could break a lot of external modules for no good reason. I agree: it also complicates the common case (calling relation_open() and