Re: [PATCHES] tuple count and v3 functions in psql for COPY

2006-03-03 Thread Bruce Momjian
Applied by Tom Lane. Thanks. --- Volkan YAZICI wrote: > On Feb 11 11:24, Bruce Momjian wrote: > > I have updated the patch to match CVS (attached), but am seeing the > > following regression differences where the COPY error

Re: [PATCHES] tuple count and v3 functions in psql for COPY

2006-03-01 Thread Volkan YAZICI
On Feb 11 11:24, Bruce Momjian wrote: > I have updated the patch to match CVS (attached), but am seeing the > following regression differences where the COPY error messages are now > missing. I've revised the patch (attached) and now it seems to be ok - passes regression tests too. Any other comme

Re: [PATCHES] tuple count and v3 functions in psql for COPY

2006-02-11 Thread Bruce Momjian
Volkan YAZICI wrote: > Here's a new try. This one touches to pg_dump side too - for v3 > COPY functions usage instead of deprecated ones. > > I'd be so appreciated if somebody can review attached patch. I have updated the patch to match CVS (attached), but am seeing the following regression diffe

Re: [PATCHES] tuple count and v3 functions in psql for COPY

2005-12-30 Thread Volkan YAZICI
I've just realized an exception in the sending data while using PQsendCopyData(). Function's blocking behaviour is not guaranteed, therefore a if (PQisnonblocking()) PQsetnonblocking(conn, 0) kind of phrase required before using PQsendCopyData(). But after a small investig

Re: [PATCHES] tuple count and v3 functions in psql for COPY

2005-12-23 Thread Volkan YAZICI
Here's a new try. This one touches to pg_dump side too - for v3 COPY functions usage instead of deprecated ones. I'd be so appreciated if somebody can review attached patch. Regards. Index: src/backend/commands/copy.c === RCS file:

Re: [PATCHES] tuple count and v3 functions in psql for COPY

2005-12-22 Thread Volkan YAZICI
On Dec 22 01:52, Tom Lane wrote: > > ! { > > ! uint64processed = DoCopy((CopyStmt *) parsetree); > > ! charbuf[21]; > > ! > > ! snprintf(buf, sizeof(buf), UINT64_FORMAT, processed); > > ! snprintf(completionTag, CO

Re: [PATCHES] tuple count and v3 functions in psql for COPY

2005-12-22 Thread Tom Lane
Volkan YAZICI <[EMAIL PROTECTED]> writes: > I tried to prepare a patch for these TODO items: > - Have COPY return the number of rows loaded/unloaded? > - Update [pg_dump and] psql to use the new COPY libpq API. > ! cstate->raw_buf_index = cstate->raw_buf_len = 0; > ! cstate->raw_buf_inde

Re: [PATCHES] tuple count and v3 functions in psql for COPY

2005-12-22 Thread Neil Conway
Volkan YAZICI wrote: I tried to prepare a patch for these TODO items: - Have COPY return the number of rows loaded/unloaded? - Update [pg_dump and] psql to use the new COPY libpq API. I'll apply this today or tomorrow, barring any objections. BTW, if we're using an int64 counter for the # of

[PATCHES] tuple count and v3 functions in psql for COPY

2005-12-18 Thread Volkan YAZICI
I tried to prepare a patch for these TODO items: - Have COPY return the number of rows loaded/unloaded? - Update [pg_dump and] psql to use the new COPY libpq API. Added an "uint64 processed" to "struct CopyStateData". It's incremented each time on a tuple send/receive made by CopyTo/CopyFrom. Co