Re: [PATCHES] tzcode update

2008-02-20 Thread Heikki Linnakangas
Tom Lane wrote: Magnus Hagander [EMAIL PROTECTED] writes: On Mon, Feb 18, 2008 at 04:32:58PM +0100, Bjorn Munch wrote: Ouch! This fails on our Solaris builds, because we build with the Solaris timezone files. And these apparently don't work beyond 2038 and don't know that Finland plans to

Re: [PATCHES] tzcode update

2008-02-18 Thread Magnus Hagander
On Mon, Feb 18, 2008 at 04:32:58PM +0100, Bjorn Munch wrote: On 13/02 10.51, Heikki Linnakangas wrote: Heikki Linnakangas wrote: I'll add some tests to cover timestamps 2038. Attached is a new patch, with a couple of new regression tests. No other changes. Ouch! This fails on our

Re: [PATCHES] tzcode update

2008-02-18 Thread Bjorn Munch
On 13/02 10.51, Heikki Linnakangas wrote: Heikki Linnakangas wrote: I'll add some tests to cover timestamps 2038. Attached is a new patch, with a couple of new regression tests. No other changes. Ouch! This fails on our Solaris builds, because we build with the Solaris timezone files.

Re: [PATCHES] tzcode update

2008-02-18 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: On Mon, Feb 18, 2008 at 04:32:58PM +0100, Bjorn Munch wrote: Ouch! This fails on our Solaris builds, because we build with the Solaris timezone files. And these apparently don't work beyond 2038 and don't know that Finland plans to have DST also in

Re: [PATCHES] tzcode update

2008-02-18 Thread Bjorn Munch
On 18/02 14.22, Tom Lane wrote: I can't imagine that fixing this isn't pretty darn high on the Solaris to-do list, anyway. Financial apps doing, say, 30-year mortgage projections are broken *today* on platforms without post-Y2038 calendar support. Well, it IS mentioned in the BUGS section of

Re: [PATCHES] tzcode update

2008-02-16 Thread Tom Lane
Heikki Linnakangas [EMAIL PROTECTED] writes: Heikki Linnakangas wrote: I'll add some tests to cover timestamps 2038. Attached is a new patch, with a couple of new regression tests. No other changes. Applied with minor revisions --- I found a couple of portability problems while testing

Re: [PATCHES] tzcode update

2008-02-14 Thread Heikki Linnakangas
Tom Lane wrote: Heikki Linnakangas [EMAIL PROTECTED] writes: Looking closer, I don't understand how that change was supposed to do anything. The point of that patch is to avoid an off-by-one result for years BC. The direction of rounding in integer division with a negative numerator is

Re: [PATCHES] tzcode update

2008-02-13 Thread Heikki Linnakangas
I just noticed that I had accidentally reverted this change in the patch: /* * Note: the point of adding 4800 is to ensure we make the same * assumptions as Postgres' Julian-date routines about the placement of * leap years in centuries BC, at least back to

Re: [PATCHES] tzcode update

2008-02-13 Thread Tom Lane
Heikki Linnakangas [EMAIL PROTECTED] writes: Looking closer, I don't understand how that change was supposed to do anything. The point of that patch is to avoid an off-by-one result for years BC. The direction of rounding in integer division with a negative numerator is undefined in C (or at

[PATCHES] tzcode update

2008-02-11 Thread Heikki Linnakangas
We included the public domain timezone library by Arthur David Olson back in 2004 into our source tree, but we haven't kept it up to date with the upstream changes since. We've made a number of small changes to our version of the library, including: - formatting changes, mostly thanks to

Re: [PATCHES] tzcode update

2008-02-11 Thread Tom Lane
Heikki Linnakangas [EMAIL PROTECTED] writes: I was not able to find anything like release notes that would list the differences between tzcode2003e, which I believe is the version that we included back then, and the latest version tzcode2007k. So I just took a diff between those, and