Tom Lane wrote:
Christopher Kings-Lynne [EMAIL PROTECTED] writes:
Hang on a second. Has someone considered the encoding issues this might
suffer from, same as PQescapeString?
That was the point I raised when I saw the commit.
My advice is we shouldn't have PQescapeIdentifier at all.
Hang on a second. Has someone considered the encoding issues this might
suffer from, same as PQescapeString? I remember we discussed it briefly
and I mentioned it's outta my league to prove one way or the other...
Bruce Momjian wrote:
Christopher Kings-Lynne wrote:
TODO item done for 8.2:
Christopher Kings-Lynne wrote:
TODO item done for 8.2:
* Add PQescapeIdentifier() to libpq
Someone probably needs to check this :)
Updated patch applied. Thanks.
--
Bruce Momjian [EMAIL PROTECTED]
EnterpriseDBhttp://www.enterprisedb.com
+ If your life is a hard drive,
Bruce Momjian [EMAIL PROTECTED] writes:
* Add PQescapeIdentifier() to libpq
Updated patch applied. Thanks.
Have either of you inquired into the encoding-safety of this code?
It certainly looks like no consideration was given for that.
regards, tom lane
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
* Add PQescapeIdentifier() to libpq
Updated patch applied. Thanks.
Have either of you inquired into the encoding-safety of this code?
It certainly looks like no consideration was given for that.
I thought of that but I assume we
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
Have either of you inquired into the encoding-safety of this code?
It certainly looks like no consideration was given for that.
I thought of that but I assume we were not accepting user-supplied
identifiers for this --- that this was
Tom Lane wrote:
Bruce Momjian [EMAIL PROTECTED] writes:
Tom Lane wrote:
Have either of you inquired into the encoding-safety of this code?
It certainly looks like no consideration was given for that.
I thought of that but I assume we were not accepting user-supplied
identifiers for
Christopher Kings-Lynne [EMAIL PROTECTED] writes:
Yes, phpPgAdmin sure would. I imagine this would be a nightmare to
address properly, so perhaps we should remove the function :(
Well, it's fixable, cf PQescapeStringConn, but we should fix it *before*
it gets into the field not after.
