Bruce Momjian writes:
> Tom Lane wrote:
>> You realize this is a waste of code, no?
> I guess, but the person reported a leak so I figured I would fix it.
I don't really care whether there's a free() there or not --- what
bothers me is that calling it a leak shows a fundamental
misunderstanding
Tom Lane wrote:
> Bruce Momjian writes:
> >> BTW, I found memory leak in BootStrapXLOG(). The buffer allocated by
> >> malloc()
> >> is not free()ed. ISSUE_BOOTSTRAP_MEMORYLEAK in this patch points out it.
> >> (But this leak is not serious, because this function is called only once.)
>
> > Does
Bruce Momjian writes:
>> BTW, I found memory leak in BootStrapXLOG(). The buffer allocated by malloc()
>> is not free()ed. ISSUE_BOOTSTRAP_MEMORYLEAK in this patch points out it.
>> (But this leak is not serious, because this function is called only once.)
> Does the following patch fix the memor
ITAGAKI Takahiro wrote:
> Hello everyone.
>
> I fixed two bugs in the patch that I sent before.
> Check and test new one, please.
>
> 1. Fix update timing of Write->curridx. (pointed by Tom)
> Change to update it soon after write().
>
> 2. Fix buffer alignment routine on 64bit cpu. (pointed
On Thu, Feb 03, 2005 at 07:25:55PM +0900, ITAGAKI Takahiro wrote:
> Hello everyone.
>
> I fixed two bugs in the patch that I sent before.
> Check and test new one, please.
Ok, finally got back into the office and was able to run 1 set of
tests.
So the new baseline result with 8.0.1:
http
This has been saved for the 8.1 release:
http://momjian.postgresql.org/cgi-bin/pgpatches2
---
ITAGAKI Takahiro wrote:
> Hello everyone.
>
> I fixed two bugs in the patch that I sent before.
> Check and test new one
Hello everyone.
I fixed two bugs in the patch that I sent before.
Check and test new one, please.
1. Fix update timing of Write->curridx. (pointed by Tom)
Change to update it soon after write().
2. Fix buffer alignment routine on 64bit cpu. (pointed by Mark)
I checked it on Xeon EM64T
