Re: [PATCHES] [pgsql-hackers-win32] Data directory with trailing [back]slash

2004-07-11 Thread Bruce Momjian
I am now confused about the original report. I don't see how my fix would correct the reported problem. trim_trailing_separator() would have handled d:\pgdata\ and d:\pgdata just fine. The fix only corrects d:\. Magnus, does current CVS fix the problem?

Re: [PATCHES] [pgsql-hackers-win32] Data directory with trailing [back]slash

2004-07-11 Thread Bruce Momjian
I think this still is not fixed. I think we need to add a call to trim_trailing_separator() in checkDataDir(). Magnus, can you confirm this will fix it? --- Bruce Momjian wrote: I am now confused about the original

Re: [PATCHES] [pgsql-hackers-win32] Data directory with trailing [back]slash

2004-07-11 Thread Bruce Momjian
Oops, path patch attached. --- Bruce Momjian wrote: I think this still is not fixed. I think we need to add a call to trim_trailing_separator() in checkDataDir(). Magnus, can you confirm this will fix it?

Re: [PATCHES] [pgsql-hackers-win32] Data directory with trailing [back]slash

2004-07-10 Thread Bruce Momjian
OK, I have fixed the problem. While your patch got close, it is best to fix the problem in trim_trailing_separator() rather than above. Tom already fixed the Unix case by preventing a path of '/' from being stripped. This patch prevents c:/ and //network/ from being stripped too. (Tom already

Re: [PATCHES] [pgsql-hackers-win32] Data directory with trailing [back]slash

2004-06-20 Thread Andrew Dunstan
Tom Lane wrote: Magnus Hagander [EMAIL PROTECTED] writes: It's not possible to start the postmaster on win32 with: postmaster -D d:\pgdata\ or postmaster -D d:/pgdata/ Sounds like canonicalize_path() needs to be applied a bit sooner than it is. BTW I think canonicalize_path() is a few