Tom Lane wrote:
I got interested enough in the psql-with-flex problem to go off and
solve it. Attached is a working patch, which I'm now debating whether
to apply. Comments solicited...
The patch removes about 200 lines of very spaghetti-ish code in
mainloop.c. However, it adds an 875-line
Tom Lane wrote:
I got interested enough in the psql-with-flex problem to go off and
solve it. Attached is a working patch, which I'm now debating whether
to apply. Comments solicited...
The patch removes about 200 lines of very spaghetti-ish code in
mainloop.c. However, it adds an
Tom Lane [EMAIL PROTECTED] writes:
I'm inclined to apply this but I can see where a person not comfortable
with flex might feel differently. Opinions?
Looks good to me. The psql cleanup is nice, and ISTM that much of the
flex code is comments or flex boilerplate anyway, so the actual LOC
Neil Conway [EMAIL PROTECTED] writes:
Tom Lane [EMAIL PROTECTED] writes:
I'm inclined to apply this but I can see where a person not comfortable
with flex might feel differently. Opinions?
Looks good to me. The psql cleanup is nice, and ISTM that much of the
flex code is comments or flex
Andrew Dunstan [EMAIL PROTECTED] writes:
Am I missing something, or is dollar quoting not in this patch?
It is not. If we go this way, then we'd add essentially identical
flex patches to backend and psql to implement dollar quoting (plus
perhaps a few more lines in psql to support signaling
Tom Lane wrote:
I got interested enough in the psql-with-flex problem to go off and
solve it. Attached is a working patch, which I'm now debating
whether to apply. Comments solicited...
That should teach me a lesson not to leave random comments lying around
in the source code. Years later
