Re: [PATCHES] Fix oversight in pts_error_callback()

2005-08-10 Thread Qingqing Zhou
"Tom Lane" <[EMAIL PROTECTED]> writes: > > That's a contrived example (and if I believed it, I would think that the > right answer is to emit no errcontext if the elevel is less than ERROR). > Yes, I've thought about ignore errcontext by considering elevel. But I scratched the source code for oth

Re: [PATCHES] Fix oversight in pts_error_callback()

2005-08-10 Thread Tom Lane
"Qingqing Zhou" <[EMAIL PROTECTED]> writes: > "Tom Lane" <[EMAIL PROTECTED]> writes >> Please exhibit a case in which you feel this is needed. > Suppose I want to print a debug info in parseTypeString() like this: > + elog(DEBUG1, "parse type %s", buf.data); > raw_parsetree_list = raw_par

Re: [PATCHES] Fix oversight in pts_error_callback()

2005-08-09 Thread Qingqing Zhou
"Tom Lane" <[EMAIL PROTECTED]> writes > > Please exhibit a case in which you feel this is needed. > Suppose I want to print a debug info in parseTypeString() like this: + elog(DEBUG1, "parse type %s", buf.data); raw_parsetree_list = raw_parser(buf.data); Rebuild the server, psql it:

Re: [PATCHES] Fix oversight in pts_error_callback()

2005-08-09 Thread Tom Lane
"Qingqing Zhou" <[EMAIL PROTECTED]> writes: > Since we will invoke callback functions unconditionally in errfinish(), so > pts_error_callback() should not report "invalid type name" without checking > current error status. Please exhibit a case in which you feel this is needed.