Re: [PATCHES] Proposed patch to change TOAST compression strategy for 8.3.4

2008-09-30 Thread Simon Riggs
On Mon, 2008-09-29 at 12:32 +0200, Jérôme Jouanin wrote: > Upgrade 8.3.4 is available. Before compiling, I have to apply the > optimized toast patch : bin7hetTGkMRL.bin. > > There are differences in 1 of the 3 files patched : tuptoaster.c > > The patch runs successfully but before installing on

Re: [PATCHES] Proposed patch to change TOAST compression strategy

2008-03-07 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > "Tom Lane" <[EMAIL PROTECTED]> writes: >> * Adds an early-failure path to the compressor as suggested by Jan: >> if it's been unable to find even one compressible substring in the >> first 1KB (parameterizable), assume we're looking at incompressible >> i

Re: [PATCHES] Proposed patch to change TOAST compression strategy

2008-02-29 Thread Teodor Sigaev
Tsvector dump (taken by Magnus from mail archives of pgsql's lists) http://www.sigaev.ru/misc/tstest.sql.bz2 Query: select sum(ts_rank( vector, 'asdfjkl' )) from tstest ; ts_rank detoasts value in any case, even tsvector doesn't contain needed lexemes. Test was on my notebook: Core2 Duo 1.8MH

Re: [PATCHES] Proposed patch to change TOAST compression strategy

2008-02-20 Thread Jan Wieck
On 2/18/2008 5:33 AM, Gregory Stark wrote: "Tom Lane" <[EMAIL PROTECTED]> writes: * Adds an early-failure path to the compressor as suggested by Jan: if it's been unable to find even one compressible substring in the first 1KB (parameterizable), assume we're looking at incompressible input and

Re: [PATCHES] Proposed patch to change TOAST compression strategy

2008-02-19 Thread Magnus Hagander
On Tue, Feb 19, 2008 at 06:46:24PM +0300, Teodor Sigaev wrote: > Magnus, could you provide dump of tsvector column of archive search? > I'll make a test with and without Tom's patch. > > >>>I have not done any performance testing of these changes --- does > >>>anyone have specific test scenarios t

Re: [PATCHES] Proposed patch to change TOAST compression strategy

2008-02-19 Thread Teodor Sigaev
Magnus, could you provide dump of tsvector column of archive search? I'll make a test with and without Tom's patch. I have not done any performance testing of these changes --- does anyone have specific test scenarios they'd like to try? -- Teodor Sigaev E-ma

Re: [PATCHES] Proposed patch to change TOAST compression strategy

2008-02-18 Thread Tom Lane
Teodor Sigaev <[EMAIL PROTECTED]> writes: >> I have not done any performance testing of these changes --- does >> anyone have specific test scenarios they'd like to try? > That's very important change for text search, because of tsvector storage. > Headline and rank reads a lot of tsvectors. It s

Re: [PATCHES] Proposed patch to change TOAST compression strategy

2008-02-18 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > * Adds an early-failure path to the compressor as suggested by Jan: > if it's been unable to find even one compressible substring in the > first 1KB (parameterizable), assume we're looking at incompressible > input and give up. (There are various ways this

Re: [PATCHES] Proposed patch to change TOAST compression strategy

2008-02-18 Thread Teodor Sigaev
> This proposed patch addresses some issues in TOAST compression strategy that I have not done any performance testing of these changes --- does anyone have specific test scenarios they'd like to try? That's very important change for text search, because of tsvector storage. Headline and rank