Re: [PATCHES] SGML index build fix

2007-01-07 Thread Peter Eisentraut
Bruce Momjian wrote: > I wrote: > > ifeq (,$(wildcard bookindex.valid)) > echo "Run 'gmake' again to generate output with a proper index" > endif > > but that warns on the first _two_ runs, meaning it expanded at the > time the rule started, not at the time it hit that lin

Re: [PATCHES] SGML index build fix

2007-01-07 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian wrote: > > The attached patch warns users when they create documentation output > > that has no index, and suggests re-running 'gmake'. > > > ! # for some reason $wildcard expands too early, so we use 'test' > > $wildcard is expanded whenever you tell it to

Re: [PATCHES] SGML index build fix

2007-01-07 Thread Peter Eisentraut
Bruce Momjian wrote: > The attached patch warns users when they create documentation output > that has no index, and suggests re-running 'gmake'. > ! # for some reason $wildcard expands too early, so we use 'test' $wildcard is expanded whenever you tell it to. What did you write? > ! @test

Re: [PATCHES] SGML index build fix

2007-01-06 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > The attached patch warns users when they create documentation output > > that has no index, and suggests re-running 'gmake'. > > This is just useless noise. If it could tell the difference between an > up-to-date index and a not-up-t

Re: [PATCHES] SGML index build fix

2007-01-06 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > The attached patch warns users when they create documentation output > that has no index, and suggests re-running 'gmake'. This is just useless noise. If it could tell the difference between an up-to-date index and a not-up-to-date one, there might be s