Re: [PATCHES] WIP CSV logs

2007-06-29 Thread Dave Page
Andrew Dunstan wrote: > > Further update attached. Includes some code cleanup, and now sets up a > session-id for all processes, including postmaster, syslogger etc, so we > can make a primary key on the log table of (session_id, line_number). > > TODOs: fix on Windows, docs. I'm not going to be

Re: [PATCHES] WIP CSV logs

2007-06-29 Thread Andrew Dunstan
Andrew Dunstan wrote: Andrew Dunstan wrote: Here is a WIP patch of the CSV logs work brought up to date with CVS HEAD. One large change I made was to multiplex the selects on the pipes - previously it waited on one then the other - this seems almost to defeat the purpose of using select

Re: [PATCHES] WIP CSV logs

2007-06-28 Thread Andrew Dunstan
Andrew Dunstan wrote: Here is a WIP patch of the CSV logs work brought up to date with CVS HEAD. One large change I made was to multiplex the selects on the pipes - previously it waited on one then the other - this seems almost to defeat the purpose of using select() :-) It seems to work

Re: [PATCHES] WIP csv logs

2007-06-06 Thread Andrew Dunstan
Tom Lane wrote: Alvaro Herrera <[EMAIL PROTECTED]> writes: I wonder, if we were to use an LWLock to protect writing to the stderr pipe, would it be too contentious? Sorry, that's a nonstarter. 1. Not all our processes are connected to shared memory. Even the ones that are don't nec

Re: [PATCHES] WIP csv logs

2007-06-06 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > I wonder, if we were to use an LWLock to protect writing to the stderr > pipe, would it be too contentious? Sorry, that's a nonstarter. 1. Not all our processes are connected to shared memory. Even the ones that are don't necessarily have PGPROCs. 2.

Re: [PATCHES] WIP csv logs

2007-06-06 Thread Andrew Dunstan
Alvaro Herrera wrote: Andrew Dunstan wrote: Attached is my WIP version of the CSV logs patch. It does not include docs changes. It fixes the CSV thinko I just posted about, and also implements the "safe to rotate" scheme I suggested yesterday, at quite a modest cost. As Tom rightly poin

Re: [PATCHES] WIP csv logs

2007-06-06 Thread Alvaro Herrera
Andrew Dunstan wrote: > > Attached is my WIP version of the CSV logs patch. It does not include > docs changes. > > It fixes the CSV thinko I just posted about, and also implements the > "safe to rotate" scheme I suggested yesterday, at quite a modest cost. > As Tom rightly points out, that do