Re: [PATCHES] fix windows contrib compile warnings for redefined

2004-10-21 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > I didn't. In one case (IDIGNORE) I changed the name of the macro to > avoid the conflict, and in the other (V_UKNOWN) I removed the Windows > def which has no applicability in that context (the Windows version > comes from oleauto.h). Both of these c

Re: [PATCHES] fix windows contrib compile warnings for redefined macros

2004-10-21 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: >> The right thing for the min/max macros is to get rid of them anyway, >> and use the Min/Max macros from c.h. > That's a fair point. I'll look at that. Actually I'm in the middle of doing that myself, so don't worry about it. r

Re: [PATCHES] fix windows contrib compile warnings for redefined

2004-10-21 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: This patch fixes contrib so that it compiles under windows without warnings about redefines for min, max, V_UNKNOWN and IDIGNORE Surely this is wrong. You might be able to assume that Windows' definitions for min/max are the same

Re: [PATCHES] fix windows contrib compile warnings for redefined macros

2004-10-21 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > This patch fixes contrib so that it compiles under windows without > warnings about redefines for min, max, V_UNKNOWN and IDIGNORE Surely this is wrong. You might be able to assume that Windows' definitions for min/max are the same as what this code i