Re: [PATCHES] include compile problems

2006-07-14 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Patch applied. Thanks. I suspect the point was that limits.h is needed *instead of* math.h, not *in addition to*. How many of those headers had math.h before? The issue was that an include file included another include file that had

Re: [PATCHES] include compile problems

2006-07-13 Thread Bruce Momjian
Patch applied. Thanks. --- Kris Jurka wrote: The attached patch makes the tree build for me again after the recent include changes. This patch still violates the postgres.h before all system headers rule and I'm

Re: [PATCHES] include compile problems

2006-07-13 Thread Tom Lane
Kris Jurka [EMAIL PROTECTED] writes: The attached patch makes the tree build for me again after the recent include changes. This patch still violates the postgres.h before all system headers rule and I'm still not sure what changed that broke everything, but if people need to get work done

Re: [PATCHES] include compile problems

2006-07-13 Thread Bruce Momjian
Tom Lane wrote: Kris Jurka [EMAIL PROTECTED] writes: The attached patch makes the tree build for me again after the recent include changes. This patch still violates the postgres.h before all system headers rule and I'm still not sure what changed that broke everything, but if people

Re: [PATCHES] include compile problems

2006-07-13 Thread Kris Jurka
On Fri, 14 Jul 2006, Tom Lane wrote: I think that Bruce thought that math.h defines INT_MAX and related symbols, whereas the spec is perfectly clear that they're in limits.h. However, that's where they are on my machines, and yet CVS tip is not failing for me. I'm not clear why not... What