Re: [PATCHES] pg_dump problems against 7.0

2003-10-21 Thread Bruce Momjian
Applied by Tom. Thanks. --- Christopher Kings-Lynne wrote: > >>Doh. Quite right. Well, the 7.0 initdb creates pg_indexes as the last > >>thing it does. (Even though there are higher oids in pg_attribute, > >>pg_rewrite

Re: [PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: >> Is this supposed to be applied to CVS? > Well, yes. Assuming Tom doesn't have any problem with it. In fact, I was just about to apply it myself (had a bit of a problem with the comment still...) regards, tom lane ---

Re: [PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Christopher Kings-Lynne wrote: > >>Doh.

Re: [PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Christopher Kings-Lynne
Is this supposed to be applied to CVS? Well, yes. Assuming Tom doesn't have any problem with it. It's a bug in dumping 7.0 databases, which should be fixed so that people can upgrade to 7.4 with less stress :) Chris ---(end of broadcast)--- TI

Re: [PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Bruce Momjian
Is this supposed to be applied to CVS? --- Christopher Kings-Lynne wrote: > >>Doh. Quite right. Well, the 7.0 initdb creates pg_indexes as the last > >>thing it does. (Even though there are higher oids in pg_attribute,

Re: [PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Christopher Kings-Lynne
Doh. Quite right. Well, the 7.0 initdb creates pg_indexes as the last thing it does. (Even though there are higher oids in pg_attribute, pg_rewrite and pg_description.), so how about the attached patch? Seems reasonable, but the patch ought to fix the comment just above, preferably with the

Re: [PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: >> Won't that result in *everything* being considered a system table? > Doh. Quite right. Well, the 7.0 initdb creates pg_indexes as the last > thing it does. (Even though there are higher oids in pg_attribute, > pg_rewrite and pg_descriptio

Re: [PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Christopher Kings-Lynne
Won't that result in *everything* being considered a system table? Doh. Quite right. Well, the 7.0 initdb creates pg_indexes as the last thing it does. (Even though there are higher oids in pg_attribute, pg_rewrite and pg_description.), so how about the attached patch? Chris Index: pg_dump.c

Re: [PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > res = PQexec(g_conn, > ! "SELECT oid from pg_database where datname = 'template1'"); > res = PQexec(g_conn, > ! "SELECT oid FROM pg_class ORDER BY oid DESC LIMIT 1"); Won't that result in