ITAGAKI Takahiro <[EMAIL PROTECTED]> writes:
> I'm worried that we leave garbage entries in the stats. As you suggested,
> don't we need to remove unreferenced entries from stats periodically?
VACUUM does that already.
regards, tom lane
---(end of
Tom Lane <[EMAIL PROTECTED]> wrote:
> > What I'm inclined to propose is that we just remove the
> > pgstat_drop_relation() call from smgr_internal_unlink
> On checking the CVS history, that in fact is how the code worked before
> 8.1.3, when I introduced the bogus call in a fit of over-optimizati
I wrote:
> What I'm inclined to propose is that we just remove the
> pgstat_drop_relation() call from smgr_internal_unlink, and rely entirely
> on VACUUM to clean out dead entries in the pgstats data.
On checking the CVS history, that in fact is how the code worked before
8.1.3, when I introduced
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes:
> I wrote:
>>> pgstat_drop_relation() is expecting relid (pg_class.oid) as the argument,
>>> but we pass it relfilenode.
> Here is a patch to fix undropped entries in the runtime statistics table.
> Now smgr records the relation oids and uses them to dr
