Re: [PATCHES] contrib mode - pgenv

2003-09-21 Thread Peter Eisentraut
Mike Mascari writes: > Out of sheer shame for a stupid remark, I have implemented a pgenv > contrib module which provides three functions: > > set_session_variable (name, value) > get_session_variable (name) > reset_session_variables() How is this better than temporary tables? -- Peter Eisentra

Re: [PATCHES] Align large shared memory allocations

2003-09-21 Thread Manfred Spraul
Tom Lane wrote: Manfred Spraul <[EMAIL PROTECTED]> writes: Attached is a patch that aligns large shared memory allocations beyond MAXIMUM_ALIGNOF. The reason for this is that Intel's cpus have a fast path for bulk memory copies that only works with aligned addresses. This patch is missin

Re: [PATCHES] contrib mode - pgenv

2003-09-21 Thread Mike Mascari
Peter Eisentraut wrote: > Mike Mascari writes: > > >>Out of sheer shame for a stupid remark, I have implemented a pgenv >>contrib module which provides three functions: >> >>set_session_variable (name, value) >>get_session_variable (name) >>reset_session_variables() > > > How is this better tha

Re: [PATCHES] contrib mode - pgenv

2003-09-21 Thread Mike Mascari
I wrote: > Peter Eisentraut wrote: > >>How is this better than temporary tables? > > Well, I basically implemented it as a result of this thread: > > http://archives.postgresql.org/pgsql-general/2003-09/msg01347.php I should also point out that if the idea were to be accepted as a contrib modu

Re: [PATCHES] contrib mode - pgenv

2003-09-21 Thread Peter Eisentraut
Mike Mascari writes: > Well, I basically implemented it as a result of this thread: > > http://archives.postgresql.org/pgsql-general/2003-09/msg01347.php We've rejected session variables many times before because they duplicate temporary tables. I don't see anything new added by this proposal.

Re: [PATCHES] contrib mode - pgenv

2003-09-21 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Mike Mascari writes: >> Well, I basically implemented it as a result of this thread: >> http://archives.postgresql.org/pgsql-general/2003-09/msg01347.php > We've rejected session variables many times before because they duplicate > temporary tables.

Re: [PATCHES] Align large shared memory allocations

2003-09-21 Thread Tom Lane
Manfred Spraul <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> This patch is missing a demonstration that it's actually worth anything. >> What kind of performance gain do you get? >> > 7.4cvs on a 1.13 GHz Intel Celeron mobile, 384 MB RAM, "Severn" RedHat > Linux 2.4 beta, postmaster -N 30 -B 6

[PATCHES] bug fix: TupleDescGetAttInMetadata/BuildTupleFromCStrings with dropped cols

2003-09-21 Thread Joe Conway
I discovered that TupleDescGetAttInMetadata and BuildTupleFromCStrings don't deal well with tuples having dropped columns. The attached fixes the issue. Please apply. Thanks, Joe Index: src/backend/executor/execTuples.c === RCS fil