Re: [PATCHES] [HACKERS] Cannot dump/restore text value \N

2003-10-08 Thread Manfred Koizar
On Sun, 05 Oct 2003 19:12:50 -0400, Tom Lane <[EMAIL PROTECTED]> wrote: >it seems we have to compare the null representation string to the >pre-debackslashing input. Here is a patch that does this and adds a few regression tests. >(This is probably fairly easy to make happen >in CVS tip, but it m

Re: [PATCHES] [HACKERS] Cannot dump/restore text value \N

2003-10-08 Thread Manfred Koizar
On Wed, 08 Oct 2003 11:31:30 +0200, I wrote: >There haven't been too much changes in this area between 7.3 and 7.4. Here is the patch for 7.3.4 ... Bruce, I noticed that the original patch submission didn't contain anything useful as a cvs log message: Make COPY FROM a bit more compatible with C

Re: [PATCHES] [HACKERS] Cannot dump/restore text value \N

2003-10-08 Thread Bruce Momjian
Manfred Koizar wrote: > On Wed, 08 Oct 2003 11:31:30 +0200, I wrote: > >There haven't been too much changes in this area between 7.3 and 7.4. > > Here is the patch for 7.3.4 ... > > Bruce, I noticed that the original patch submission didn't contain > anything useful as a cvs log message: > > Mak

[PATCHES] Spanish translations of pg_dump and pg_resetxlog

2003-10-08 Thread Manuel Sugawara
pg_dump-es.pot.bz2 Description: Spanish translation of pg_dump pg_resetxlog-es.pot.bz2 Description: Spanish translation of pg_resetxlog Regards, Manuel. ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister comma

Re: [PATCHES] [HACKERS] pg_restore -d doesn't display output

2003-10-08 Thread Peter Eisentraut
Bruce Momjian writes: > I have patched pg_restore to output the script contents if you restore > with -v: I don't think it's a good idea to overload the -v switch with it. A separate switch seems OK, but I don't quite get the point of this functionality, actually. -- Peter Eisentraut [EMAIL

Re: [PATCHES] [HACKERS] pg_restore -d doesn't display output

2003-10-08 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian writes: > > > I have patched pg_restore to output the script contents if you restore > > with -v: > > I don't think it's a good idea to overload the -v switch with it. A > separate switch seems OK, but I don't quite get the point of this > functionality, a

[PATCHES] akward wording in autovacuum README

2003-10-08 Thread Robert Treat
Change some awkward wording in the pg_autovacuum README file. I really only read this because of Niel :-) Robert Treat -- Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL Index: README.pg_autovacuum === RCS file: /projec

Re: [PATCHES] akward wording in autovacuum README

2003-10-08 Thread Bruce Momjian
Patch applied. Thanks. --- Robert Treat wrote: > Change some awkward wording in the pg_autovacuum README file. I really > only read this because of Niel :-) > > Robert Treat > -- > Build A Brighter Lamp :: Linux Apache {

Re: [PATCHES] [HACKERS] Cannot dump/restore text value \N

2003-10-08 Thread Manfred Koizar
On Wed, 8 Oct 2003 11:33:24 -0400 (EDT), Bruce Momjian <[EMAIL PROTECTED]> wrote: >Can someone explain what was broken? COPY FROM removed backslashes before comparing the input to the external null representation. (It had a hard-wired special code path that allowed \N to be recognized.) The text

Re: [PATCHES] Spanish translations of pg_dump and pg_resetxlog

2003-10-08 Thread Peter Eisentraut
Installed. Next time, please run msgfmt -o /dev/null -c -v file.po, or use the equivalent command in your PO editor, to check your file for errors. -- Peter Eisentraut [EMAIL PROTECTED] ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postma

Re: [PATCHES] fix log_min_duration_statement logic error

2003-10-08 Thread Peter Eisentraut
Bruce Momjian writes: > > Imagine someone always having log_statement on and doing some sort of > > aggregate query counting, say like grep '^LOG: query:' | wc -l. Now that > > someone (or maybe the admin on the night shift, to make it more dramatic) > > also turns on log_min_statement_duration (

Re: [PATCHES] fix log_min_duration_statement logic error

2003-10-08 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian writes: > > > > Imagine someone always having log_statement on and doing some sort of > > > aggregate query counting, say like grep '^LOG: query:' | wc -l. Now that > > > someone (or maybe the admin on the night shift, to make it more dramatic) > > > also t

Re: [PATCHES] [HACKERS] Cannot dump/restore text value \N

2003-10-08 Thread Tom Lane
Manfred Koizar <[EMAIL PROTECTED]> writes: > Should I send a new patch with only the regression tests? Yeah, if you think they are worth adding. regards, tom lane ---(end of broadcast)--- TIP 9: the planner will ignore your

Re: [PATCHES] [HACKERS] Cannot dump/restore text value \N

2003-10-08 Thread Tom Lane
Manfred Koizar <[EMAIL PROTECTED]> writes: > Here is a patch that does this and adds a few regression tests. Uh, I did that already ... for 7.4 at least. regards, tom lane ---(end of broadcast)--- TIP 9: the planner will ign

Re: [PATCHES] fix log_min_duration_statement logic error

2003-10-08 Thread Bruce Momjian
OK, patch attached and applied. Changes are: "query:" now "statement:" log_duration also now prints when log_min_duration_statement prints --- Peter Eisentraut wrote: > Bruce Momjian writes: > > > > Imagi

Re: [PATCHES] fix log_min_duration_statement logic error

2003-10-08 Thread Bruce Momjian
pgman wrote: > > OK, patch attached and applied. Changes are: > > "query:" now "statement:" > log_duration also now prints when log_min_duration_statement prints Oh, sample is: LOG: statement: select 1; LOG: duration: 0.329 ms LOG: duration: 0.329 ms statement: select 1; --