[PATCHES] SIGPIPE handling, take two.

2003-11-02 Thread Manfred Spraul
pqsecure_write tries to catch SIGPIPE signals generated by network disconnects by setting the signal handler to SIG_IGN. The current approach causes several problems: - it always sets SA_RESTART when it restores the old handler. - it's not reliable for multi threaded apps, because another thread

[PATCHES] psql: \dg and groups for \du

2003-11-02 Thread Markus Bertheau
Hi, attached is a patch that adds display of the groups a user belongs to to \du and a \dg command to psql. It's against 7.4beta5. -- Markus Bertheau <[EMAIL PROTECTED]> diff -ru postgresql-7.4beta5.orig/src/bin/psql/command.c postgresql-7.4beta5/src/bin/psql/command.c --- postgresql-7.4beta5.or

[PATCHES] UW 713UP3 patch

2003-11-02 Thread Larry Rosenman
Since peter objects to my methods, what is an ACCEPTABLE way to detect the 7.1.3UP3 compiler? I'd like to get this fixed for RC1. LER -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 972-414-9812 E-Mail: [EMAIL PROTECTED] US Mail: 1905 Steamboat Springs D

Re: [PATCHES] UW 713UP3 patch

2003-11-02 Thread Peter Eisentraut
Larry Rosenman writes: > Since peter objects to my methods, what is an ACCEPTABLE way to detect > the 7.1.3UP3 compiler? One POSSIBLE way to do this properly is to write a test that 1) Uses $CC, $CFLAGS, and related variables rather than hardcoding 'cc -O'. 2) Names any test files conftest.*, s

Re: [PATCHES] UW 713UP3 patch

2003-11-02 Thread Larry Rosenman
--On Sunday, November 02, 2003 22:26:40 +0100 Peter Eisentraut <[EMAIL PROTECTED]> wrote: Larry Rosenman writes: Since peter objects to my methods, what is an ACCEPTABLE way to detect the 7.1.3UP3 compiler? One POSSIBLE way to do this properly is to write a test that 1) Uses $CC, $CFLAGS, and

Re: [PATCHES] UW 713UP3 patch

2003-11-02 Thread Peter Eisentraut
Larry Rosenman writes: > The problem is MOST people will **NOT** be able to get the fixed compiler > as it's on the Upgrade Pack path (PAY FOR), and **NOT** the Maintenance > Pack path (Free). Why did they upgrade to the broken compiler in the first place, and why doesn't SCO provide free fixes f

Re: [PATCHES] "make check" improvement for cygwin

2003-11-02 Thread Tom Lane
"Andrew Dunstan" <[EMAIL PROTECTED]> writes: > Well, I posted the note last night but I finished the patch today, because > it was very simple and took so little time. I've committed this with the later revision about the warning message, and some other minor cleanups. I added documentation in th

Re: [PATCHES] UW 713UP3 patch

2003-11-02 Thread Larry Rosenman
--On Sunday, November 02, 2003 23:05:21 +0100 Peter Eisentraut <[EMAIL PROTECTED]> wrote: Larry Rosenman writes: The problem is MOST people will **NOT** be able to get the fixed compiler as it's on the Upgrade Pack path (PAY FOR), and **NOT** the Maintenance Pack path (Free). Why did they upgr

Re: [PATCHES] UW 713UP3 patch

2003-11-02 Thread Larry Rosenman
--On Sunday, November 02, 2003 15:29:37 -0600 Larry Rosenman <[EMAIL PROTECTED]> wrote: I'll try and write the patch as you suggest. Here's a patch as you suggested: Index: src/template/unixware === RCS file: /projects/cvsroot/pg

Re: [PATCHES] UW 713UP3 patch

2003-11-02 Thread Tom Lane
Larry Rosenman <[EMAIL PROTECTED]> writes: > +# version check for the 7.1.3UP3 compiler (version 401200310): > +cat >conftest.c <<__EOF__ > +int main(int argc, char **argv) > +#if __SCO_VERSION__ >=3D 401200310 > +#error good compiler > +#else > +#error bad compiler > +#endif > +__EOF__ > + $CC co

Re: [PATCHES] UW 713UP3 patch

2003-11-02 Thread Larry Rosenman
--On Sunday, November 02, 2003 18:17:26 -0500 Tom Lane <[EMAIL PROTECTED]> wrote: Larry Rosenman <[EMAIL PROTECTED]> writes: +# version check for the 7.1.3UP3 compiler (version 401200310): +cat >conftest.c <<__EOF__ +int main(int argc, char **argv) +#if __SCO_VERSION__ >=3D 401200310 +#error go

Re: [PATCHES] UW 713UP3 patch

2003-11-02 Thread Larry Rosenman
--On Sunday, November 02, 2003 17:23:59 -0600 Larry Rosenman <[EMAIL PROTECTED]> wrote: --On Sunday, November 02, 2003 18:17:26 -0500 Tom Lane <[EMAIL PROTECTED]> wrote: Larry Rosenman <[EMAIL PROTECTED]> writes: +# version check for the 7.1.3UP3 compiler (version 401200310): +cat >conftest.c

Re: [PATCHES] "make check" improvement for cygwin

2003-11-02 Thread Andrew Dunstan
Tom Lane wrote: "Andrew Dunstan" <[EMAIL PROTECTED]> writes: Well, I posted the note last night but I finished the patch today, because it was very simple and took so little time. I've committed this with the later revision about the warning message, and some other minor cleanups. I add

[PATCHES] Two very minor win32 patches

2003-11-02 Thread Claudio Natoli
For src/backend/postmaster/postmaster.c and src/include/c.h (Note: should ioctlsocket_ret be initialized to 1 for BEOS too, and can it take an unsigned parameter? If so, could simplify.) --- WE HAVE MOVED - PLEASE NOTE OUR NEW CONTACT DETAILS: THE BASEMENT, 33 EWELL STREET, BALMAIN NSW 2041

[PATCHES] Win32 patch for Makefile.shlib

2003-11-02 Thread Claudio Natoli
If this is acceptable, I'll send a similar one for src/backend/Makefile Cheers, Claudio --- WE HAVE MOVED - PLEASE NOTE OUR NEW CONTACT DETAILS: THE BASEMENT, 33 EWELL STREET, BALMAIN NSW 2041 TEL: +61 2 9555 1544 FAX: +61 2 9555 6911 Certain disclaimers and policies apply to all email sent

[PATCHES] bufmgr code cleanup

2003-11-02 Thread Neil Conway
This patch cleans up some of the bufmgr code: - replace uses of LockBuffer(buf, BUFFER_LOCK_UNLOCK); ReleaseBuffer(buf); with the equivalent, but more concise: UnlockAndReleaseBuffer(buf); - analogous changes were made by replacing LockBuffer() + WriteBuffer()