Re: [PATCHES] [patch] 7.4 initdb - drop trailing slash from $PGDATA

2004-01-19 Thread Andrew Dunstan
Tom Lane said: > Peter Eisentraut <[EMAIL PROTECTED]> writes: >> Jari Aalto wrote: >>> I made a mistake while running 7.4 under W2k/Cygwin, so perhaps the >>> patch would give user a little more comfort. > >> I don't see how. Please explain. > > CVS-tip initdb seems to be written to suppress any t

Re: [PATCHES] psql prompts with invisible characters

2004-01-19 Thread Reece Hart
On Fri, 2004-01-16 at 13:34, Tom Lane wrote: how far back do they have support for these RL_PROMPT_foo symbols, and do we need to consider the possibility that the symbols aren't there or act differently? Short answer: I believe that any readline newer than Feb 1999 oughta work. The RL_PRO

[PATCHES] Patch for search_path --- apply to 7.4 branch?

2004-01-19 Thread Tom Lane
Attached is the patch I just applied to CVS HEAD to fix the search_path problem that Olivier Prenant recently identified (can't set a search path for another database if it mentions schemas not present in the current database). I am looking for comments on whether to back-patch this into REL7_4_ST

Re: [PATCHES] psql prompts with invisible characters

2004-01-19 Thread Tom Lane
Reece Hart <[EMAIL PROTECTED]> writes: > The RL_PROMPT_* markers are undocumented features of readline. The patch > I sent works fine with RL 4.2 and 4.3 on linux-x86. From the readline > changelogs, I deduced that these were added with 4.0 (ca. Feb 1999). Hm. I don't recall whether we still pret

[PATCHES] trivial typos

2004-01-19 Thread Alvaro Herrera
Attached is a patch that fixes some trivial typos and alignment. Please apply. -- Alvaro Herrera () "Siempre hay que alimentar a los dioses, aunque la tierra esté seca" (Orual) diff -cr --exclude=CVS 00orig/src/backend/access/transam/xact.c 01trivial/src/backend/access/transam/xact.c *** 00orig

[PATCHES] small smgr refactoring

2004-01-19 Thread Alvaro Herrera
I attach a small patch that slightly refactors some code in storage/smgr/smgr.c. Regression test pass. There's no change in functionality, only code reordering. (Well, it changes an ad-hoc linked list into a proper List). Please review and if Ok, apply. -- Alvaro Herrera () "At least to kerne

Re: [PATCHES] small smgr refactoring

2004-01-19 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > (Well, it changes an ad-hoc linked > list into a proper List). Why? AFAICT that just makes the code bigger, uglier, and slower ... I am pretty dubious of PendingDeletesBeginXact, too, and of moving this list out of TopMemoryContext. Please justify.

Re: [PATCHES] small smgr refactoring

2004-01-19 Thread Alvaro Herrera
On Mon, Jan 19, 2004 at 06:20:21PM -0500, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > (Well, it changes an ad-hoc linked > > list into a proper List). > > Why? AFAICT that just makes the code bigger, uglier, and slower ... Oh, does it? Hmm. When I originally wrote this, it