[PATCHES] Link errors on win32

2004-05-28 Thread Thomas Hallgren
After patching postmaster.c (see previous post) I'm unable to link on win32 (mingw). I get the following errors: gcc -O2 -fno-strict-aliasing -Wall -Wmissing-prototypes -Wmissing-declaratio ns -L../../src/port -o postgres.exe -Wl,--base-file,postgres.base postgres.exp access/SUBSYS.o

[PATCHES] thread safety testing fix

2004-05-28 Thread Andreas Pflug
When checking for thread safety with src/tools/thread/thread_test.c, the mktemp function wants an argument that contains 6 X, while the current version only supplies 5 X which will fail on my SuSE 8.1. Patch attached. Regards, Andreas Index: thread_test.c

[PATCHES] Compiling libpq with VisualC

2004-05-28 Thread Andreas Pflug
Some modifications are needed to compile libpq with vc6: fe-connect.c: - pg_config_paths.h isn't available. SYSCONFDIR is already defined so fe-connect.c doesn't need to include that. patch appended win32.mak: - pg_config.h must be generated - port/pgstrcasecmp.c is needed - port/path.c is not

Re: [PATCHES] Link errors on win32

2004-05-28 Thread Thomas Hallgren
Magnus Hagander [EMAIL PROTECTED] writes: This looks like it's missing stuff from Bruces move from backend/port/win32 to port/kill.c of the kill signal. Are you sure you pulled a new version of the port directory as well? And did you do a make clean? I did a make clean. But it encountered an

[PATCHES] Libpq ssl fix

2004-05-28 Thread Andreas Pflug
init_ssl_system will return 0 on success and -1 on failure, which will be interpreted just the other way round in initialize_SSL. Patch appended. Regards, Andreas Index: fe-secure.c === RCS file:

Re: [PATCHES] postmaster.c doesn't compile on win32

2004-05-28 Thread Tom Lane
Thomas Hallgren [EMAIL PROTECTED] writes: The CVS HEAD of postmaster.c doesn't compile on win32 . Here's a patch that removes some warnings and typos. Fixed ... sorry 'bout that. (For future reference: I couldn't use your patch as-is because your mailer converted all the tabs to spaces. I'd

Re: [PATCHES] Libpq ssl fix

2004-05-28 Thread Andreas Pflug
Manfred Spraul wrote: Btw, --enable-thread-safety on Linux (RedHat Fedora Core 1) fails in configure with configure: error: *** Thread test program failed. Your platform is not thread-safe. *** Check the file 'config.log'for the exact reason. I had this too, for two reasons: - configure

Re: [PATCHES] thread safety testing fix

2004-05-28 Thread Tom Lane
Andreas Pflug [EMAIL PROTECTED] writes: When checking for thread safety with src/tools/thread/thread_test.c, the mktemp function wants an argument that contains 6 X, while the current version only supplies 5 X which will fail on my SuSE 8.1. Patch attached. Isn't this going to break

Re: [PATCHES] Link errors on win32

2004-05-28 Thread Thomas Hallgren
Tom Lane wrote: Thomas Hallgren [EMAIL PROTECTED] writes: I did a make clean. But it encountered an error and terminated prematurely and I missed it... make[2]: Entering directory `/ws/pgsql/contrib/earthdistance' make[2]: *** No rule to make target `clean'. Stop. make[2]: Leaving

Re: [PATCHES] patch for different join result order on regression test for

2004-05-28 Thread Andrew Dunstan
Andrew Dunstan wrote: This resultmap patch and regression test result file allow the join regression test to succeed under Mingw. Could someone please add the join result I posted in the original of this email (on May 10th) as src/test/regress/expected/join_1.out? This is the one test I am

Re: [PATCHES] Link errors on win32

2004-05-28 Thread Bruce Momjian
Thomas Hallgren wrote: Magnus Hagander [EMAIL PROTECTED] writes: This looks like it's missing stuff from Bruces move from backend/port/win32 to port/kill.c of the kill signal. Are you sure you pulled a new version of the port directory as well? And did you do a make clean? I did a make

Re: [PATCHES] thread safety testing fix

2004-05-28 Thread Andreas Pflug
Tom Lane wrote: Andreas Pflug [EMAIL PROTECTED] writes: When checking for thread safety with src/tools/thread/thread_test.c, the mktemp function wants an argument that contains 6 X, while the current version only supplies 5 X which will fail on my SuSE 8.1. Patch attached. Isn't this

Re: [PATCHES] thread safety testing fix

2004-05-28 Thread Bruce Momjian
Tom Lane wrote: Andreas Pflug [EMAIL PROTECTED] writes: When checking for thread safety with src/tools/thread/thread_test.c, the mktemp function wants an argument that contains 6 X, while the current version only supplies 5 X which will fail on my SuSE 8.1. Patch attached. Isn't this

Re: [PATCHES] Link errors on win32

2004-05-28 Thread Tom Lane
Thomas Hallgren [EMAIL PROTECTED] writes: I did a make clean. But it encountered an error and terminated prematurely and I missed it... make[2]: Entering directory `/ws/pgsql/contrib/earthdistance' make[2]: *** No rule to make target `clean'. Stop. make[2]: Leaving directory

Re: [PATCHES] Libpq ssl fix

2004-05-28 Thread Andreas Pflug
Tom Lane wrote: Andreas Pflug [EMAIL PROTECTED] writes: init_ssl_system will return 0 on success and -1 on failure, which will be interpreted just the other way round in initialize_SSL. Patch appended. Hmm, that looks backwards to me too, but this would seem to imply that Manfred Spraul

Re: [PATCHES] mingw configure failure detection

2004-05-28 Thread Bruce Momjian
OK, fixed. --- Andrew Dunstan wrote: Bruce Momjian wrote: Andrew Dunstan wrote: following up our conversation last night, I have tested the following with autoconf 2.57 and it apparently does the right thing:

Re: [PATCHES] Link errors on win32

2004-05-28 Thread Thomas Hallgren
Bruce Momjian wrote: Thomas Hallgren wrote: Magnus Hagander [EMAIL PROTECTED] writes: This looks like it's missing stuff from Bruces move from backend/port/win32 to port/kill.c of the kill signal. Are you sure you pulled a new version of the port directory as well? And did you do a make

Re: [PATCHES] Link errors on win32

2004-05-28 Thread Tom Lane
Thomas Hallgren [EMAIL PROTECTED] writes: Ah yes. Actually, this is the error I got once I manually created the earthdistance directory in order for the clean to proceed. The first time it failed, it was missing altogether. Ah. earthdistance is in a separate CVS module (a remnant of a

Re: [PATCHES] Libpq ssl fix

2004-05-28 Thread Manfred Spraul
Hi, I'll retest the patch. I didn't have a working ssl test setup, thus I stopped when I ran into the same errors as without my patch. Probably printfs in initialize_SSL(), but no tests that the code beyond initialize_SSL() actually runs - sorry. Btw, --enable-thread-safety on Linux (RedHat

[PATCHES] fix for pg_regress.sh on mingw

2004-05-28 Thread Andrew Dunstan
With the attached patch make check runs cleanly for me under MSys/Mingw. Description of changes: . only use the -W flag on pwd for $pkglibdir. All the other paths need to be seen as MSys type paths, whereas $pkglibdir needs to be expressed as a genuine windows path. . run single tests in the

Re: [PATCHES] Libpq ssl fix

2004-05-28 Thread Manfred Spraul
Bruce Momjian wrote: - patch for thread_test.c needed posted some hours ago. Applied. The current CVS tree work again, Andreas' patch fixed the configure failure. Additionally Andreas' libpq patch fixes ssl. I've tested the locking, too: ssl calls pq_lockingcallback. I've tested it by

Re: [PATCHES] Libpq ssl fix

2004-05-28 Thread Bruce Momjian
You will find Anreas's two patches in the patch queue. Are there more changes than that? --- Manfred Spraul wrote: Bruce Momjian wrote: - patch for thread_test.c needed posted some hours ago. Applied.

Re: [PATCHES] psql prompts with invisible characters

2004-05-28 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Your patch has been added to the PostgreSQL unapplied patches list at: Uh, wasn't this applied some time ago? regards, tom lane ---(end of broadcast)--- TIP 1: subscribe and

Re: [PATCHES] Moving pg_autovacuum from contrib to src/bin

2004-05-28 Thread Matthew T. O'Connor
On Sat, 2004-05-29 at 01:31, Matthew T. O'Connor wrote: Having no response from my email to hackers yesterday, I will assume (hope) that no news is good news and proceed onwards. As outlined in my email, step 1 is to move pg_autovacuum from contrib to src/bin. Attached is a patch that