Re: [PATCHES] ALTER INDEX

2004-08-20 Thread Bruce Momjian
Gavin Sherry wrote: > On Fri, 20 Aug 2004, Tom Lane wrote: > > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > No, but it is a missing capability many will complain about. I can > > > easily remove it. I saw no one comment when I added it to the patches > > > queue. > > > > I hadn't seen you a

Re: [PATCHES] pg_restore recognizing $-quotes

2004-08-20 Thread Bruce Momjian
Patch applied. Thanks. --- Philip Warner wrote: > > Not sure if this is the desired approach, but since it works, I thought I'd > send it. > > This patch allows pg_restore to recognize $-quotes in SQL queries. It will

Re: [PATCHES] psql tab-complete patch #3

2004-08-20 Thread Bruce Momjian
Great, patch applied. I merged it into Gavin's recent ALTER INDEX addition. I have added your list of uncompleted items to the TODO list. --- Stefan Kaltenbrunner wrote: > Hi all! > > Attached is the third version of my p

Re: [PATCHES] compile fix for contrib/fuzzystrmatch

2004-08-20 Thread Bruce Momjian
Patch applied. Thanks. --- Richard Poole wrote: > I notice that contrib/fuzzystrmatch/dmetaphone.c doesn't compile cleanly > as it stands - it mixes declarations in code, C++-style. The attached > patch shifts declarations

[PATCHES] pg_dump print error location

2004-08-20 Thread Bruce Momjian
Patch applied. Thanks. --- Philip Warner wrote: > At 01:32 AM 16/08/2004, Tom Lane wrote: > >It'd be substantially *more* helpful if it reported the failing command. > > They are two different problems; the TOC entry is i

Re: [PATCHES] ALTER SCHEMA ... SET TABLESPACE

2004-08-20 Thread Bruce Momjian
This has been saved for the 8.1 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 --- Gavin Sherry wrote: > This patch implements ALTER SCHEMA ... SET TABLESPACE. > > This changes the default schema tablespa

Re: [PATCHES] [BUGS] BUG #1219: pgxs does not work fully

2004-08-20 Thread Bruce Momjian
Patch applied. Thanks. --- pgman wrote: > > Your patch has been added to the PostgreSQL unapplied patches list at: > > http://momjian.postgresql.org/cgi-bin/pgpatches > > It will be applied as soon as one of the P

Re: [PATCHES] [HACKERS] Added schema selection to pg_restore

2004-08-20 Thread Bruce Momjian
This has been saved for the 8.1 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 --- Richard van den Berg wrote: > Since I needed this feature badly, I added the -n / --schema switch to > pg_restore. It res

Re: [PATCHES] [HACKERS] 7.4.3 & 8.0.0beta1 + Solaris 9: default pg_hba.conf

2004-08-20 Thread Bruce Momjian
Patch applied. Thanks. --- Andrew Dunstan wrote: > > > Tom Lane wrote: > > >Andrew Dunstan <[EMAIL PROTECTED]> writes: > > > > > >>At this stage of the game I would just change pg_hba.conf.sample to use > >>'127.0.0.

Re: [PATCHES] psql tab-complete patch #3

2004-08-20 Thread Stefan Kaltenbrunner
Bruce Momjian wrote: Great, patch applied. I merged it into Gavin's recent ALTER INDEX addition. Many thanks for applying my first patch, but looking at result I noticed that you have removed INDEX from the list_ALTER which looks like a possible merge-error to me(Garry added that one in his orig

Re: [PATCHES] [pgsql-hackers-win32] Service startup delay

2004-08-20 Thread Bruce Momjian
OK, I started running tests with pg_ctl -w and found it did not work even on Unix. I found that the code was not checking the return value of PQsetdbLogin(), and wasn't looping properly using a sleep. The attached applied patch should fix should fix your reported problem. --