[PATCHES] Repleacement for src/port/snprintf.c

2005-02-09 Thread Nicolai Tufar
Hello all, I would like to submit my changes to src/port/snprintf.c to enable %n$ format placeholder replacement in snprintf() and vsnprintf(). Additionally I implemented a trivial printf(). I also attach a diff for configure.in to include snprintf.o in pgport but I am sure it is not the right

Re: [PATCHES] dbsize patch

2005-02-09 Thread Ed L.
On Thursday February 3 2005 9:23, Ed L. wrote: Neil, do you have a verdict on this patch? On Friday January 28 2005 10:30, Ed L. wrote: If the C code for the prior dbsize patch is not acceptable for whatever reason, here's a SQL-based patch to replace it. I submitted a dbsize patch on Jan

Re: [PATCHES] memory leak in ALTER TABLE

2005-02-09 Thread Neil Conway
On Wed, 2005-02-09 at 15:56 +1100, Neil Conway wrote: This patch changes ATRewriteTable() to switch to the per-tuple memory context before beginning the per-tuple loop. [...] Barring any objections, I will apply this to HEAD and REL8_0_STABLE tomorrow. Applied. -Neil

Re: [PATCHES] dbsize patch

2005-02-09 Thread Bruce Momjian
It is still in my mailbox for review. Sorry. --- Ed L. wrote: On Thursday February 3 2005 9:23, Ed L. wrote: Neil, do you have a verdict on this patch? On Friday January 28 2005 10:30, Ed L. wrote: If the C code

Re: [PATCHES] dbsize patch

2005-02-09 Thread Neil Conway
On Wed, 2005-02-09 at 18:35 -0500, Bruce Momjian wrote: It is still in my mailbox for review. Sorry. Yeah, my apologies as well, I've been busy with other things. Bruce, if you'd like to review apply this you are welcome to. Otherwise let me know and I'll take a look. -Neil

Re: [PATCHES] dbsize patch

2005-02-09 Thread Bruce Momjian
Neil Conway wrote: On Wed, 2005-02-09 at 18:35 -0500, Bruce Momjian wrote: It is still in my mailbox for review. Sorry. Yeah, my apologies as well, I've been busy with other things. Bruce, if you'd like to review apply this you are welcome to. Otherwise let me know and I'll take a look.

Re: [PATCHES] WIP: pl/pgsql cleanup

2005-02-09 Thread Neil Conway
Another version of the patch is attached. Changes: - clean up grammar so that read_sql_construct() is always called to read a well-formed SQL expression. That way we can check for errors in embedded SQL by just adding a single function call to read_sql_construct(), rather than adding calls at

Re: [PATCHES] WIP: pl/pgsql cleanup

2005-02-09 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: create function bad_sql1() returns int as $$ declare a int; begin a := 5; Johnny Yuma; a := 10; return a; end$$ language 'plpgsql'; ERROR: syntax error at or near Johnny CONTEXT: SQL statement embedded in PL/PgSQL function bad_sql1

Re: [PATCHES] Clarify use of NOW() in pl/pgsql docs

2005-02-09 Thread Neil Conway
On Thu, 2005-01-27 at 02:28 -0800, David Fetter wrote: This one from Ben Calvert. It uses the (imho clearer) NOW() rather than 'NOW' in a PL/PgSQL function example. Applied, thanks. -Neil ---(end of broadcast)--- TIP 3: if posting/reading

Re: [PATCHES] [Fwd: Re: [DOCS] Instructions for FreeBSD ipc config

2005-02-09 Thread Neil Conway
Applied, thanks. On Wed, 2005-02-02 at 17:33 +1300, Mark Kirkwood wrote: As discussed on -docs. (Not really sure if I need to explicitly forward here) Yeah, forwarding (or CC'ing) to -patches is helpful. -Neil ---(end of broadcast)--- TIP

Re: [PATCHES] WIP: pl/pgsql cleanup

2005-02-09 Thread Neil Conway
On Wed, 2005-02-09 at 23:57 -0500, Tom Lane wrote: That seems like a step backwards from the current behavior [...] Hmm, fair enough. Is this better? create function bad_sql1() returns int as $$ declare a int; begin a := 5; Johnny Yuma; a := 10; return a; end$$ language