Re: [PATCHES] PL/Python patch for Universal Newline Support

2005-03-21 Thread Michael Fuhr
On Mon, Mar 21, 2005 at 02:50:47AM -0500, Tom Lane wrote: > Michael Fuhr <[EMAIL PROTECTED]> writes: > > The operative word there was "how" :-) I don't see anything testing > > PL/{Python,Perl,Tcl} under src/test/regress -- should I put something > > there? > > No. > > The PLs have their own reg

Re: [PATCHES] PL/Python patch for Universal Newline Support

2005-03-21 Thread Tom Lane
Michael Fuhr <[EMAIL PROTECTED]> writes: > On Mon, Mar 21, 2005 at 02:50:47AM -0500, Tom Lane wrote: >> The PLs have their own regression tests in their individual src/pl >> directories; feel free to hack on those (most are pretty lame :-() > Thanks -- I'll add some tests there and resubmit. One

Re: [PATCHES] PL/Python patch for Universal Newline Support

2005-03-21 Thread Michael Fuhr
On Mon, Mar 21, 2005 at 03:02:57AM -0500, Tom Lane wrote: > > One thing that needs some thought is how you are going to test this > robustly. I'd not feel any great deal of confidence in a test that > expects that we can push \r\n sequences into CVS and expect them to > survive unmodified into di

Re: [PATCHES] PL/Python patch for Universal Newline Support

2005-03-21 Thread Michael Fuhr
On Mon, Mar 21, 2005 at 01:19:35AM -0700, Michael Fuhr wrote: > We're testing what happens when \r gets into prosrc, right? Shouldn't > creating the function with \r in single quotes instead of dollar > quotes work, as in the tests I showed in my original submission? ...or what about a little sc

Re: [PATCHES] PL/Python patch for Universal Newline Support

2005-03-21 Thread Andrew Dunstan
Michael Fuhr said: > On Mon, Mar 21, 2005 at 03:02:57AM -0500, Tom Lane wrote: >> >> One thing that needs some thought is how you are going to test this >> robustly. I'd not feel any great deal of confidence in a test that >> expects that we can push \r\n sequences into CVS and expect them to >> s

Re: [PATCHES] PL/Python patch for Universal Newline Support

2005-03-21 Thread Tom Lane
Michael Fuhr <[EMAIL PROTECTED]> writes: > We're testing what happens when \r gets into prosrc, right? Shouldn't > creating the function with \r in single quotes instead of dollar > quotes work, as in the tests I showed in my original submission? Yeah, that should work. I was too tired to think