Re: [PATCHES] [BUGS] BUG #1563: wrong week returnded by date_trunc('week',

2005-03-29 Thread Robert Creager
When grilled further on (Tue, 29 Mar 2005 07:43:53 +0200), Dirk Raetzel <[EMAIL PROTECTED]> confessed: > > > On Mon, 28 Mar 2005, Bruce Momjian wrote: > > > I have developed a patch to fix the problem. Instead of changing the > > API, I added code to decrement the year when the week number was

Re: [PATCHES] [WIP] shared row locks

2005-03-29 Thread Alvaro Herrera
On Mon, Mar 28, 2005 at 11:18:05PM -0500, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > 1. To examine a tuple one must first call LockTuple, which grabs a pin > > and lock in the buffer. The buffer lock is released right away, but the > > pin is kept. > > Surely you don't mean

[PATCHES] unused variable ShmemBootstrap

2005-03-29 Thread Alvaro Herrera
Patchers, src/backend/storage/shmem.c contains an unused variable; it's only assigned to, and used in a couple Assert(). It's been this way since shmem.c 1.53, which was current on july 2000. This patch removes it, along with an obsolete comment (which refers to a file and function that hasn't e

Re: [PATCHES] unused variable ShmemBootstrap

2005-03-29 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > This patch removes it, along with an obsolete comment (which refers to a > file and function that hasn't existed at all in the whole CVS history.) I agree that the code is useless, but exactly which comment are you complaining of?

Re: [PATCHES] [BUGS] BUG #1563: wrong week returnded by date_trunc('week',

2005-03-29 Thread Bruce Momjian
Robert Creager wrote: -- Start of PGP signed section. > When grilled further on (Tue, 29 Mar 2005 07:43:53 +0200), > Dirk Raetzel <[EMAIL PROTECTED]> confessed: > > > > > > > On Mon, 28 Mar 2005, Bruce Momjian wrote: > > > > > I have developed a patch to fix the problem. Instead of changing th