Heikki,
Good patch.
...The patch makes no mention of temporary files, which are left there
after a crash.
Temp files are only removed on a normal startup, whereas the patch
invokes removal on both normal startup and crash recovery. That doesn't
make much sense...
Also, temp file deletion
Oliver Jowett wrote:
Here's a patch that adds four new GUCs:
I haven't had a chance to check it builds on other systems or to test
that this handles actual network failures nicely yet.
The patch builds OK on Solaris 9, which doesn't have the required socket
options.
Solaris (and some other
FYI, his patch is in CVS and now only _reports_ unreferenced files, and
it happens on recovery and normal startup.
---
Simon Riggs wrote:
Heikki,
Good patch.
...The patch makes no mention of temporary files, which
The issue has been raised in the past that our build system links each
executable against the maximal set of libraries it might need. So for
example, if one executable requires `libreadline', all executables are
linked against it.
The easiest fix is to make use of GNU ld's --as-needed flag,
Neil Conway [EMAIL PROTECTED] writes:
The easiest fix is to make use of GNU ld's --as-needed flag, which
ignores linker arguments that are not actually needed by the specified
object files. The attached patch modifies configure to check for this
flag (when using GNU ld),
Minor gripe ---
Tom Lane wrote:
Minor gripe --- what's the motivation for moving this down as you did?
What do you mean by this? I moved the AC_MSG_NOTICEs for CPPFLAGS and
LDFLAGS down below the --as-needed check, since the --as-needed check
may modify LDFLAGS.
Also, please s/same platforms/some platforms/
Neil Conway [EMAIL PROTECTED] writes:
Tom Lane wrote:
Minor gripe --- what's the motivation for moving this down as you did?
What do you mean by this? I moved the AC_MSG_NOTICEs for CPPFLAGS and
LDFLAGS down below the --as-needed check, since the --as-needed check
may modify LDFLAGS.
Tom Lane wrote:
Well, I guess the question is why you put the --as-needed check where
you did, rather than above the existing AC_MSG_NOTICE displays. If it
has an interaction with the intervening tests, what is that exactly?
PGAC_PROG_LD needs to be invoked to figure out if we're using gnu ld.
