Re: [PATCHES] [PATCH] Formatting patch for psql

2005-11-25 Thread Martijn van Oosterhout
On Thu, Nov 24, 2005 at 09:23:55PM -0500, Tom Lane wrote: Martijn van Oosterhout kleptog@svana.org writes: And what I'm saying is that you can only do that if all single byte encodings are ASCII compatable and I'm not prepared to say that... psql already assumes that; see the flex

Re: [PATCHES] [PATCH] Formatting patch for psql

2005-11-25 Thread Tom Lane
Martijn van Oosterhout kleptog@svana.org writes: ... There is a fair bit of encoding code in there already but the information you need here is specifically: is this char a control character and in particular, is it a newline. The appropriate test for that is just ch == '\n', in all the

[PATCHES] is not distinct from

2005-11-25 Thread Pavel Stehule
Hello small patch, add form is not distinct from expression (sql2003) regards Pavel Stehule _ Emotikony a pozadi programu MSN Messenger ozivi vasi konverzaci. http://messenger.msn.cz/ diff -c -r pgsql.old/doc/src/sgml/func.sgml

Re: [PATCHES] [PATCH] Formatting patch for psql

2005-11-25 Thread Martijn van Oosterhout
On Fri, Nov 25, 2005 at 09:58:21AM -0500, Tom Lane wrote: Martijn van Oosterhout kleptog@svana.org writes: ... There is a fair bit of encoding code in there already but the information you need here is specifically: is this char a control character and in particular, is it a newline.

Re: [PATCHES] [PATCH] Formatting patch for psql

2005-11-25 Thread Tom Lane
Martijn van Oosterhout kleptog@svana.org writes: Would people prefer a patch that brought the libpq routines up to scratch and have mbprint use that? I would. regards, tom lane ---(end of broadcast)--- TIP 2: Don't 'kill

Re: [PATCHES] [PATCH] Formatting patch for psql

2005-11-25 Thread Martijn van Oosterhout
On Fri, Nov 25, 2005 at 11:08:45AM -0500, Tom Lane wrote: Martijn van Oosterhout kleptog@svana.org writes: Would people prefer a patch that brought the libpq routines up to scratch and have mbprint use that? I would. ACK. Will look into it. -- Martijn van Oosterhout kleptog@svana.org

Re: [PATCHES] [HACKERS] Should libedit be preferred to libreadline?

2005-11-25 Thread Bruce Momjian
Martijn van Oosterhout wrote: -- Start of PGP signed section. On Tue, Nov 22, 2005 at 10:07:15AM +0100, Zeugswetter Andreas DCP SD wrote: PS: I'd prefer if readline was only linked where it is needed, namely in psql. The problem as stated is that people don't want to maintain lists of

Re: [PATCHES] [HACKERS] Should libedit be preferred to libreadline?

2005-11-25 Thread Bruce Momjian
Jim C. Nasby wrote: On Mon, Nov 21, 2005 at 07:50:48PM -0500, Andrew Dunstan wrote: Nice analysis, but we can't hack configure like that. It has to be able to be fully generated from its sources. I think the other source file you would need to look at is config/programs.m4. (Not sure

Re: [PATCHES] [HACKERS] Should libedit be preferred to libreadline?

2005-11-25 Thread Peter Eisentraut
Bruce Momjian wrote: Why don't we have a libedit configure flag? Well, I can code up a configure flag, but that doesn't mean that the thing will compile at the end. :) -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of