[PATCHES] pl/python: fix ref leak on elog

2005-12-29 Thread Neil Conway
Attached is a simple patch that fixes a minor problem in PL/Python: in PLy_spi_execute_plan(), we invoke the input function for a Postgres data type. If that function elog's (which is quite possible), PL/Python leaks references to two temporary Python objects. The fix seems easy, albeit a bit u

Re: [PATCHES] Fix spinlock usage in UnpinBuffer()

2005-12-29 Thread Tom Lane
Qingqing Zhou <[EMAIL PROTECTED]> writes: > Remove SpinLockAcquire_NoHoldoff() and related. Now SpinLockAcquire() will > not holdoff cancle/die interrupts. This will give cleaner and clearer > useage of spinlock and also save a few cycles. Applied with some minor comment updates. I noticed that s

Re: [PATCHES] pl/python: fix ref leak on elog

2005-12-29 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Since the problem might actually occur in practice and the fix seems to > have little chance of inducing a regression, I'm thinking of applying > this to both HEAD and back branches. Barring any objections I'll do that > later today or early tomorrow. L

Re: [PATCHES] Fix spinlock usage in UnpinBuffer()

2005-12-29 Thread Qingqing Zhou
"Tom Lane" <[EMAIL PROTECTED]> wrote > > I noticed that shmem.c holds ShmemIndexLock considerably longer than any > other spinlock is held, and across operations that could theoretically > fail (hashtable manipulations). This doesn't matter a lot in the Unix > code because only the postmaster eve

Re: [PATCHES] pl/python: fix ref leak on elog

2005-12-29 Thread Neil Conway
Tom Lane wrote: Looks alright to me. Applied to HEAD, REL8_1_STABLE, and REL8_0_STABLE. -Neil ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so t

Re: [PATCHES] [HACKERS] status of concurrent VACUUM patch ...

2005-12-29 Thread Bruce Momjian
We seem to be stuck on this patch. Hannu wrote it, Tom doesn't trust it, and no one else is commenting. --- Hannu Krosing wrote: > ?hel kenal p?eval, K, 2005-12-21 kell 09:50, kirjutas Hannu Krosing: > > ?hel kenal p?eval,