Thanks!
I had misunderstood the content of the comment. I think that I can
understand the problem now.
I might be able to present the solution of the restarting an index scan.
I try to correct the patch.
Simon Riggs wrote:
> On Tue, 2006-01-31 at 15:18 +0900, Junji TERAMOTO wrote:
>> Tom Lane wr
Dave Page wrote:
> Oops. 8.0, 8.1 and dev failed on Snake last night :-(
Fixed in all branches, patch attached. I was unclear how the const was
going to behave for Win32 but it should be fine now.
Basically the const comes in via parameter, and we used to make a
non-const copy just for Win32; no
David Fetter wrote:
Anyhow, Bruce's patch still allows backslash as a delimiter, which can
cause *all* kinds of fun if not disallowed.
Yes, I'm puzzled by that. I can't really see any case for allowing it.
And if we do, it should only be allowed in CSV mode, where its use will
be mere
Thanks Bruce.
-Original Message-
From: Bruce Momjian [mailto:[EMAIL PROTECTED]
Sent: Wed 2/1/2006 12:45 PM
To: Dave Page
Cc: PostgreSQL-patches
Subject: Re: [HACKERS] FW: PGBuildfarm member snake Branch REL8_0_STABLE Status
changed from OK to Make failure
Dave Page wrote:
> Oops. 8.0,
David Fetter wrote:
> On Wed, Feb 01, 2006 at 01:16:08AM -0500, Tom Lane wrote:
> > Bruce Momjian writes:
> > > Attached is a patch that errors for \r and \n in delimiter and
> > > null. I kept the ERRCODE_FEATURE_NOT_SUPPORTED error code because
> > > that is what all the other error tests use i
test, please ignore
--
Bruce Momjian| http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup.| Newtown Square, Pennsylvania 19073
---
Tom Lane wrote:
> Bruce Momjian writes:
> > Because random returns a double, I think it is very possible that we
> > could return 1 due to rounding,
>
> Not unless your machine has a "double" type with less than 32 bits of
> precision, which seems pretty unlikely. It'd be sufficient to do
>
>
Where are we on this patch? Should we add code to do regex calls to the
backend using '~'.
---
Greg Sabino Mullane wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
> NotDashEscaped: You need GnuPG to verify this mes
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
> Where are we on this patch? Should we add code to do regex calls
> to the backend using '~'.
Yes - I am planning to submit a new patch when I get a few spare
cycles. Hopefully no more than a few days from now.
- --
Greg Sabino Mullane [EMAIL P
* Bruce Momjian (pgman@candle.pha.pa.us) wrote:
> Stephen Frost wrote:
> > Great! It'd be really nice to have this fix in 8.1.3... :)
>
> No, it will not be in 8.1.3. It is a new feature.
I'd really appriciate it if you could review my post to pgsql-bugs,
Message-ID: <[EMAIL PROTECTED]>. If th
Stephen Frost wrote:
-- Start of PGP signed section.
> * Bruce Momjian (pgman@candle.pha.pa.us) wrote:
> > Stephen Frost wrote:
> > > Great! It'd be really nice to have this fix in 8.1.3... :)
> >
> > No, it will not be in 8.1.3. It is a new feature.
>
> I'd really appriciate it if you could re
On Wed, 2006-02-01 at 17:20 -0500, Stephen Frost wrote:
> * Bruce Momjian (pgman@candle.pha.pa.us) wrote:
> > Stephen Frost wrote:
> > > Great! It'd be really nice to have this fix in 8.1.3... :)
> >
> > No, it will not be in 8.1.3. It is a new feature.
>
> I'd really appriciate it if you could
Andrew Dunstan wrote:
> On Wed, 2006-02-01 at 17:20 -0500, Stephen Frost wrote:
> > * Bruce Momjian (pgman@candle.pha.pa.us) wrote:
> > > Stephen Frost wrote:
> > > > Great! It'd be really nice to have this fix in 8.1.3... :)
> > >
> > > No, it will not be in 8.1.3. It is a new feature.
> >
> >
Bruce Momjian writes:
> Andrew Dunstan wrote:
>> I assume you are referring to this post:
>> http://archives.postgresql.org/pgsql-bugs/2006-01/msg00188.php
> OK, that helps. The solution is to "not do that", meaning install
> postgis before the restore or something. Anyway, adding the patch see
* Bruce Momjian (pgman@candle.pha.pa.us) wrote:
> Stephen Frost wrote:
> -- Start of PGP signed section.
> > * Bruce Momjian (pgman@candle.pha.pa.us) wrote:
> > > Stephen Frost wrote:
> > > > Great! It'd be really nice to have this fix in 8.1.3... :)
> > >
> > > No, it will not be in 8.1.3. It i
* Andrew Dunstan ([EMAIL PROTECTED]) wrote:
> this is a hopeless way of giving a reference. Many users don't keep list
> emails. If you want to refer to a previous post you should give a
> reference to the web archives.
Sorry, I'm actually pretty used to using Message IDs for references (we
do it
* Bruce Momjian (pgman@candle.pha.pa.us) wrote:
> Andrew Dunstan wrote:
> > this is a hopeless way of giving a reference. Many users don't keep list
> > emails. If you want to refer to a previous post you should give a
> > reference to the web archives.
> >
> > I assume you are referring to this p
* Tom Lane ([EMAIL PROTECTED]) wrote:
> Bruce Momjian writes:
> > Andrew Dunstan wrote:
> >> I assume you are referring to this post:
> >> http://archives.postgresql.org/pgsql-bugs/2006-01/msg00188.php
>
> > OK, that helps. The solution is to "not do that", meaning install
> > postgis before the
Stephen Frost <[EMAIL PROTECTED]> writes:
> * Tom Lane ([EMAIL PROTECTED]) wrote:
>> This is not super surprising because the original design approach for
>> pg_restore was "bomb out on any sort of difficulty whatsoever". That
>> was justly complained about, and now it will try to keep going after
Tom Lane said:
>
> Also, it might be possible to depend on whether libpq has entered the
> "copy in" state. I'm not sure this works very well, because if there's
> an error in the COPY command itself (not in the following data) then we
> probably don't ever get into "copy in" state.
>
Could we n
* Andrew Dunstan ([EMAIL PROTECTED]) wrote:
> Tom Lane said:
> > Also, it might be possible to depend on whether libpq has entered the
> > "copy in" state. I'm not sure this works very well, because if there's
> > an error in the COPY command itself (not in the following data) then we
> > probably
* Tom Lane ([EMAIL PROTECTED]) wrote:
> ISTM you should be depending on the archive structure: at some level,
> at least, pg_restore knows darn well whether it is dealing with table
> data or SQL commands.
Alright, to do this, ExecuteSqlCommandBuf would need to be modified to
return an error-code
* Stephen Frost ([EMAIL PROTECTED]) wrote:
> * Tom Lane ([EMAIL PROTECTED]) wrote:
> > ISTM you should be depending on the archive structure: at some level,
> > at least, pg_restore knows darn well whether it is dealing with table
> > data or SQL commands.
>
[...]
> I'd be happy to work this up, a
Stephen Frost wrote:
-- Start of PGP signed section.
> * Stephen Frost ([EMAIL PROTECTED]) wrote:
> > * Tom Lane ([EMAIL PROTECTED]) wrote:
> > > ISTM you should be depending on the archive structure: at some level,
> > > at least, pg_restore knows darn well whether it is dealing with table
> > > d
Stephen Frost <[EMAIL PROTECTED]> writes:
> I'd be happy to work this up, and I think it would work, but it seems
> kind of ugly since then we'd have ahwrite and ahprintf returning error
> codes which in 99% of the cases wouldn't be checked which doesn't seem
> terribly clean. :/
I agree. I wonde
I have researched your report, and you are right, there are two ecpg
bugs here. First, dollar quoting uses single-quotes internally to do
the quoting, but it does not double any single-quotes in the
dollar-quoted string.
Second, when a dollar quoted string or single-quoted string spans
multiple
* Tom Lane ([EMAIL PROTECTED]) wrote:
> Stephen Frost <[EMAIL PROTECTED]> writes:
> > * Tom Lane ([EMAIL PROTECTED]) wrote:
> >> This is not super surprising because the original design approach for
> >> pg_restore was "bomb out on any sort of difficulty whatsoever". That
> >> was justly complaine
27 matches
Mail list logo
