Re: [PATCHES] Free WAL caches on switching segments

2006-02-14 Thread Simon Riggs
On Mon, 2006-02-13 at 23:33 -0500, Tom Lane wrote: > Bruce Momjian writes: > > Yes, your vote counts very much. What if I apply the patch, but mark > > the posix_advise() call in a NOT_USED macro block, so it will be ready > > for people to test, but will not be used until we are sure. > > Sound

Re: [PATCHES] Free WAL caches on switching segments

2006-02-14 Thread Tom Lane
Mark Kirkwood <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Sounds like a recipe for ensuring it never will be tested. What's >> needed here is some actual tests, not preparation... > Does the OP have a test scenario that those of us with appropriate OS's > could try? Come to think of it, wha

Re: [PATCHES] Free WAL caches on switching segments

2006-02-14 Thread Simon Riggs
On Tue, 2006-02-14 at 12:54 +, Simon Riggs wrote: > On Mon, 2006-02-13 at 23:33 -0500, Tom Lane wrote: > > Bruce Momjian writes: > > > Yes, your vote counts very much. What if I apply the patch, but mark > > > the posix_advise() call in a NOT_USED macro block, so it will be ready > > > for pe

Re: [PATCHES] Free WAL caches on switching segments

2006-02-14 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > This was supposed to be a serious suggestion, so apologies if this came > across stronger than it was meant. If you want to have a serious discussion about it, you need to start a thread on pghackers under a more suitable subject line. The people reading

[PATCHES] add additional options to CREATE TABLE ... AS

2006-02-14 Thread Kris Jurka
This patch adds most of the options available for regular CREATE TABLE syntax to the CREATE TABLE x AS SELECT ... and AS EXECUTE ... Specifically this allows specification of on commit behavior for temp tables and tablespaces for regular tables to these two statements. Additionally with/witho

Re: [PATCHES] add additional options to CREATE TABLE ... AS

2006-02-14 Thread Neil Conway
On Tue, 2006-02-14 at 14:32 -0500, Kris Jurka wrote: > This patch adds most of the options available for regular CREATE TABLE > syntax to the CREATE TABLE x AS SELECT ... and AS EXECUTE ... > Specifically this allows specification of on commit behavior for temp > tables and tablespaces for regul

Re: [PATCHES] add additional options to CREATE TABLE ... AS

2006-02-14 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > The implementation is pretty ugly -- it clutters ExecuteStmt and Query > with fields that really do not belong there. Per previous discussion, I > think it would be better to refactor the CREATE TABLE AS implementation > to be essentially a CREATE TABLE fol

Re: [PATCHES] add additional options to CREATE TABLE ... AS

2006-02-14 Thread Kris Jurka
On Tue, 14 Feb 2006, Kris Jurka wrote: This patch adds most of the options available for regular CREATE TABLE syntax to the CREATE TABLE x AS SELECT ... and AS EXECUTE ... Here's the doc changes for this. Kris JurkaIndex: doc/src/sgml/ref/create_table_as.sgml =

Re: [PATCHES] Free WAL caches on switching segments

2006-02-14 Thread Mark Kirkwood
Tom Lane wrote: Mark Kirkwood <[EMAIL PROTECTED]> writes: Tom Lane wrote: Sounds like a recipe for ensuring it never will be tested. What's needed here is some actual tests, not preparation... Does the OP have a test scenario that those of us with appropriate OS's could try? Come to thin

Re: [PATCHES] Free WAL caches on switching segments

2006-02-14 Thread Tom Lane
Mark Kirkwood <[EMAIL PROTECTED]> writes: > Thinking about this, presumably any write intensive, multi-user > benchmark would seem to be suitable, so would something like OSDL's > DBT-2 actually be better to try? I'm certainly not wedded to pgbench, give it a try. BTW, I forgot to mention that

Re: [PATCHES] add additional options to CREATE TABLE ... AS

2006-02-14 Thread Kris Jurka
On Tue, 14 Feb 2006, Tom Lane wrote: I kinda wonder why bother at all. I don't see any good reason why people shouldn't issue two statements. Well if you don't know what the resulting columns are going to be that could be difficult. There are a number of reasons why this patch is an imp