[PATCHES] [PATCH] Explicit shell types

2006-02-21 Thread Martijn van Oosterhout
Hi, The only thing I considered wrong with the previous patch was it's odd behaviour w.r.t. creation of types with the same name as one in pg_catalog. However, Tom said this is not a serious issue given the same problem exists in many other places in PostgreSQL. So, I've added some regression tes

Re: [PATCHES] ScanDirections

2006-02-21 Thread Neil Conway
James William Pye wrote: In any case, some parts of the patch merely makes some code make use of the sdir.h macros instead of depending on -1/0/1--heapam in particular. At least those portions should be applied, no? I've applied the attached patch to CVS HEAD that just changes the code to use

Re: [PATCHES] [HACKERS] windows / initdb oddness

2006-02-21 Thread Andrew Dunstan
Andrew Dunstan wrote: I wrote: I will add some trace writes when I get a chance. I was rather hoping something would jump out at you, but obviously it hasn't, so I'll have to dig into it the slow way. *sigh* Just eyeballing the code it looks to me like the problem is this line:

Re: [PATCHES] [HACKERS] windows / initdb oddness

2006-02-21 Thread Magnus Hagander
> >> I will add some trace writes when I get a chance. I was > rather hoping > >> something would jump out at you, but obviously it hasn't, so I'll > >> have to dig into it the slow way. *sigh* > > > > > > > > Just eyeballing the code it looks to me like the problem is > this line: > > > >

Re: [PATCHES] Uninstall scripts for contrib

2006-02-21 Thread David Fetter
On Sat, Feb 18, 2006 at 07:08:15PM +0100, Peter Eisentraut wrote: > David Fetter wrote: > > This one should do it. > > This patch fails to apply all over the place. It applied just fine against the CVSup version. This one should apply against CVS TIP. Cheers, D -- David Fetter [EMAIL PROTECTED