Re: [PATCHES] CREATE SYNONYM ...

2006-03-08 Thread Neil Conway
On Tue, 2006-03-07 at 17:14 -0500, Tom Lane wrote: > (Actually, I don't think the case for table synonyms has been made > adequately either; "Oracle has it" is *not* enough reason to take on > another feature that we'll have to maintain forever, especially given > that we're being told that one of

Re: [PATCHES] CREATE SYNONYM ...

2006-03-08 Thread Stephen Frost
* Neil Conway ([EMAIL PROTECTED]) wrote: > BTW, AFAICS synonyms for tables and views can be approximated by views: > you pay a small runtime hit to expand the view definition, but that's > fairly cheap for a simple view. Synonyms for functions can be > approximated by shell functions defined in SQL

Re: [PATCHES] CREATE SYNONYM ...

2006-03-08 Thread Jonah H. Harris
On 3/7/06, Tom Lane <[EMAIL PROTECTED]> wrote: To be blunt, those people aren't going to be moving to Postgres anyhow.If the notion of fixing this issue daunts them, they are not going to bewilling to deal with the other incompatibilities between Oracle and PG. IMHO, we're not discussing incompati

Re: [PATCHES] CREATE SYNONYM ...

2006-03-08 Thread Jonah H. Harris
On 3/8/06, Stephan Szabo <[EMAIL PROTECTED]> wrote: Doesn't that pretty much go against the (I thought) outstanding behavioralquestion of whether the synonyms are scoped and obey search path?  If theydo, I don't see how the above rule can hold since finding the "real table" is insufficient to know

Re: [PATCHES] CREATE SYNONYM ...

2006-03-08 Thread Jonah H. Harris
On 3/8/06, Neil Conway <[EMAIL PROTECTED]> wrote: I'm inclined to agree. The points raised about the difficulties ofmanaging large numbers of schemas are legitimate, but I don't see thatsynonyms are a very effective solution. If we're going to make it lesspainful to work on applications with many t

Re: [PATCHES] CREATE SYNONYM ...

2006-03-08 Thread Jonah H. Harris
GRR, not enough coffee yet today :( Jonah now enjoys some SumatraOn 3/8/06, Jonah H. Harris <[EMAIL PROTECTED] > wrote:I agree wholeheartedly. regarding "we should take a fresh look at the problem rather than just blindly copying a construct from Oracle". SELECT dblink('host=somehost dbname=remot

Re: [PATCHES] CREATE SYNONYM ...

2006-03-08 Thread Stephan Szabo
On Wed, 8 Mar 2006, Jonah H. Harris wrote: > On 3/8/06, Stephan Szabo <[EMAIL PROTECTED]> wrote: > > > > Doesn't that pretty much go against the (I thought) outstanding behavioral > > question of whether the synonyms are scoped and obey search path? If they > > do, I don't see how the above rule

[PATCHES] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread David Fetter
Folks, >From the earlier discussion, it appears that there is a variety of opinions on what the COPY delimiter should be in pg_dump. This patch allows people to set it and the NULL string. Thanks to Gavin Sherry for help with the pointers :) I didn't patch pg_dumpall, but it would be trivial if

Re: [PATCHES] CREATE SYNONYM ...

2006-03-08 Thread Neil Conway
On Wed, 2006-03-08 at 08:16 -0500, Stephen Frost wrote: > If all you were doing with the view was reading from it then sure... > Creating the rules for all the views you want to make them updatable > wouldn't be fun. Well, updateable views are on the TODO list: expending our finite development res

Re: [PATCHES] [HACKERS] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread Tom Lane
David Fetter <[EMAIL PROTECTED]> writes: > From the earlier discussion, it appears that there is a variety of > opinions on what the COPY delimiter should be in pg_dump. This patch > allows people to set it and the NULL string. Did anyone provide a convincing use case for this? It's of zero valu

Re: [PATCHES] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread Neil Conway
On Wed, 2006-03-08 at 07:47 -0800, David Fetter wrote: > From the earlier discussion, it appears that there is a variety of > opinions on what the COPY delimiter should be in pg_dump. This patch > allows people to set it and the NULL string. I'm still not convinced there is a reasonable use-case

Re: [PATCHES] [HACKERS] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread David Fetter
On Wed, Mar 08, 2006 at 11:03:00AM -0500, Tom Lane wrote: > David Fetter <[EMAIL PROTECTED]> writes: > > From the earlier discussion, it appears that there is a variety of > > opinions on what the COPY delimiter should be in pg_dump. This > > patch allows people to set it and the NULL string. > >

Re: [PATCHES] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread David Fetter
On Wed, Mar 08, 2006 at 11:10:04AM -0500, Neil Conway wrote: > On Wed, 2006-03-08 at 07:47 -0800, David Fetter wrote: > > From the earlier discussion, it appears that there is a variety of > > opinions on what the COPY delimiter should be in pg_dump. This patch > > allows people to set it and the

Re: [PATCHES] [HACKERS] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread Tom Lane
David Fetter <[EMAIL PROTECTED]> writes: > On Wed, Mar 08, 2006 at 11:03:00AM -0500, Tom Lane wrote: >> Did anyone provide a convincing use case for this? > I've had one so far, and it was enough to cause me to make a special > patched version of pg_dump. To get some idea of how drastic that was,

Re: [PATCHES] [HACKERS] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread David Fetter
On Wed, Mar 08, 2006 at 11:26:00AM -0500, Tom Lane wrote: > David Fetter <[EMAIL PROTECTED]> writes: > > On Wed, Mar 08, 2006 at 11:03:00AM -0500, Tom Lane wrote: > >> Did anyone provide a convincing use case for this? > > > I've had one so far, and it was enough to cause me to make a > > special

Re: [PATCHES] [HACKERS] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread Greg Stark
David Fetter <[EMAIL PROTECTED]> writes: > Not everybody's editor/mailer/whatever does this right, and it makes > things fragile. Another way to do this is to change the delimter to a > printable character like '|', but that raises hackles, too. Frankly if you're passing you data through an edi

Re: [PATCHES] CREATE SYNONYM ...

2006-03-08 Thread Andreas Pflug
Neil Conway wrote: I'm still unconvinced that this feature would be sufficiently useful to justify the maintenance burden, in addition to the added complexity: even if it is implemented in a way that imposes minimal *runtime* overhead, new features add complexity: introducing a bunch of new DD

Re: [PATCHES] CREATE SYNONYM ...

2006-03-08 Thread Jonah H. Harris
On 3/8/06, Stephan Szabo <[EMAIL PROTECTED]> wrote: Yes, however there are two slightly separate discussions going on and Ithink you're taking them as a single discussion. I agree that there are two discussions happening in this thread, but I don't think anyone has agreed at all that this patch as

Re: [PATCHES] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread Neil Conway
On Wed, 2006-03-08 at 08:20 -0800, David Fetter wrote: > The previous discussion showed that there is a wide diversity of > opinions on what The Right Delimiter and The Right NULL String(TM) > are. Barring a more convincing justification for why we need this feature, I'm inclined to side with Tom:

Re: [PATCHES] CREATE SYNONYM ...

2006-03-08 Thread Stephan Szabo
On Wed, 8 Mar 2006, Jonah H. Harris wrote: > On 3/8/06, Stephan Szabo <[EMAIL PROTECTED]> wrote: > > > > Yes, however there are two slightly separate discussions going on and I > > think you're taking them as a single discussion. > > > I agree that there are two discussions happening in this thre

Re: [PATCHES] CREATE SYNONYM ...

2006-03-08 Thread Jonah H. Harris
On 3/8/06, Stephan Szabo <[EMAIL PROTECTED]> wrote: What feature though?  Part of the definition of a feature like synonym hasto nail down things like how it interacts with search pathI've said how it interacts with the search path (with Oracle) several times and illustrated it in the last one, let

Re: [PATCHES] CREATE SYNONYM ...

2006-03-08 Thread Stephan Szabo
On Wed, 8 Mar 2006, Jonah H. Harris wrote: > On 3/8/06, Stephan Szabo <[EMAIL PROTECTED]> wrote: > > > > What feature though? Part of the definition of a feature like synonym has > > to nail down things like how it interacts with search path > > > I've said how it interacts with the search path

Re: [HACKERS] [PATCHES] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread Jim C. Nasby
On Wed, Mar 08, 2006 at 04:57:52PM -0500, Neil Conway wrote: > On Wed, 2006-03-08 at 08:20 -0800, David Fetter wrote: > > The previous discussion showed that there is a wide diversity of > > opinions on what The Right Delimiter and The Right NULL String(TM) > > are. > > Barring a more convincing j

Re: [PATCHES] [HACKERS] pg_freespacemap question

2006-03-08 Thread Mark Kirkwood
Tom Lane wrote: Mark Kirkwood <[EMAIL PROTECTED]> writes: Good points! I had not noticed this test case. Probably NULL is better Would setting it to 'BLCKSZ - (fixed index header stuff)' be better, No, I don't think so, because that will just make it harder to recognize what's what (reme

Re: [PATCHES] [HACKERS] Automatic free space map filling

2006-03-08 Thread ITAGAKI Takahiro
"Zeugswetter Andreas DCP SD" <[EMAIL PROTECTED]> wrote: > Ok, we cannot reuse a dead tuple. Maybe we can reuse the space of a dead > tuple by reducing the tuple to it's header info. Attached patch realizes the concept of his idea. The dead tuples will be reduced to their headers are done by bgwri