[PATCHES] -HEAD pg_dumpall broken against older backends

2006-03-29 Thread Stefan Kaltenbrunner
Hi! looks like somebody forgot to test some changes to the pg_dumpall code in Revision 1.70 against <8.1 installations - resulting in the following syntax error: -- -- PostgreSQL database cluster dump -- \connect postgres pg_dumpall: query failed: ERROR: syntax error at or near "null" LIN

Re: [PATCHES] -HEAD pg_dumpall broken against older backends

2006-03-29 Thread Peter Eisentraut
Stefan Kaltenbrunner wrote: > looks like somebody forgot to test some changes to the pg_dumpall > code in Revision 1.70 against <8.1 installations - resulting in the > following syntax error: Dump output is never expected to be backward compatible. -- Peter Eisentraut http://developer.postgresq

Re: [PATCHES] -HEAD pg_dumpall broken against older backends

2006-03-29 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Stefan Kaltenbrunner wrote: >> looks like somebody forgot to test some changes to the pg_dumpall >> code in Revision 1.70 against <8.1 installations - resulting in the >> following syntax error: > Dump output is never expected to be backward compatib

Re: [PATCHES] -HEAD pg_dumpall broken against older backends

2006-03-29 Thread Andrew Dunstan
Peter Eisentraut wrote: Stefan Kaltenbrunner wrote: looks like somebody forgot to test some changes to the pg_dumpall code in Revision 1.70 against <8.1 installations - resulting in the following syntax error: Dump output is never expected to be backward compatible. We don't exp

Re: [PATCHES] -HEAD pg_dumpall broken against older backends

2006-03-29 Thread Stefan Kaltenbrunner
Peter Eisentraut wrote: > Stefan Kaltenbrunner wrote: > >>looks like somebody forgot to test some changes to the pg_dumpall >>code in Revision 1.70 against <8.1 installations - resulting in the >>following syntax error: > > > Dump output is never expected to be backward compatible. yeah - but

[PATCHES] restore to defaults values when commenting of variables in postgresql.conf

2006-03-29 Thread BERTHOULE Emmanuel
Hi all, with this patch, you can now restore default value with SIGHUP when commenting an variable in postgresql.conf Emmanuel BERTHOULE Index: src/backend/utils/misc/guc-file.l === RCS file: /projects/cvsroot/pgsql/src/backend/ut

Re: [PATCHES] Improve psql's handling of multi-line queries

2006-03-29 Thread Steve Woodcock
On 21/03/06, Bruce Momjian wrote: > Steve, we have already applied a patch by Sergey E. Koposov to do this. > Would you review CVS HEAD and see that everything works as you would > like. Thanks. Yeah it's good; stores multiline queries in .psql_history which is an improvement over my patch. Che

Re: [PATCHES] restore to defaults values when commenting of variables in postgresql.conf

2006-03-29 Thread Tom Lane
BERTHOULE Emmanuel <[EMAIL PROTECTED]> writes: > with this patch, you can now restore default value with SIGHUP when > commenting an variable in postgresql.conf This seems pretty poorly thought out, in particular making PGC_S_SIGHUP >= PGC_S_OVERRIDE seems to me likely to break the interaction wit

[PATCHES] Show tablespace for databases with psql's \l+

2006-03-29 Thread Philip Yarra
Following discussion (http://archives.postgresql.org/pgsql-hackers/2006-03/msg01208.php) here's a patch to add tablespace to the output of psql's \l+. New output (with psql -E) looks like this: pyarra=# \l+ * QUERY ** SELECT d.datname as "Name", r.rolname as "Owner",

Re: [PATCHES] -HEAD pg_dumpall broken against older backends

2006-03-29 Thread Andrew Dunstan
Stefan Kaltenbrunner wrote: Hi! looks like somebody forgot to test some changes to the pg_dumpall code in Revision 1.70 against <8.1 installations - resulting in the following syntax error: patch applied, thanks andrew ---(end of broadcast)---

Re: [PATCHES] Show tablespace for databases with psql's \l+

2006-03-29 Thread Tom Lane
Philip Yarra <[EMAIL PROTECTED]> writes: > Please let me know if this patch needs any changes for acceptance. I would > prefer the tablespace row to the left of Description, Me too --- that looks pretty weird as-is. regards, tom lane ---(end of br

Re: [PATCHES] Show tablespace for databases with psql's \l+

2006-03-29 Thread Philip Yarra
On Thu, 30 Mar 2006 01:13 pm, Tom Lane wrote: > Philip Yarra <[EMAIL PROTECTED]> writes: > > Please let me know if this patch needs any changes for acceptance. I > > would prefer the tablespace row to the left of Description, > > Me too --- that looks pretty weird as-is. OK, revised patch attached