Re: [PATCHES] SPI-header-files safe for C++-compiler

2007-06-29 Thread Jacob Rief
On Thu, 2007-28-06 at 01:15 -0400, Tom Lane wrote: > Sure, but we don't break them just on a whim. The bottom line here is > whether we are going to make a real commitment to making C++ usable as > a backend extension language --- and for the reasons I mentioned, that > would entail a lot more tha

Re: [PATCHES] SPI-header-files safe for C++-compiler

2007-06-29 Thread Marko Kreen
On 6/29/07, Jacob Rief <[EMAIL PROTECTED]> wrote: On Thu, 2007-28-06 at 01:15 -0400, Tom Lane wrote: > Sure, but we don't break them just on a whim. The bottom line here is > whether we are going to make a real commitment to making C++ usable as > a backend extension language --- and for the rea

Re: [PATCHES] configure.in / xml / quoting trouble

2007-06-29 Thread Patrick Welche
On Thu, Jun 28, 2007 at 04:16:37PM -0400, Tom Lane wrote: > Patrick Welche <[EMAIL PROTECTED]> writes: > > The thing is, if xml2-config is meant to give the flags necessary to > > compile a programme with libxml, then why pick-and-choose which flags > > you are going to use? > > Well, if they gave

Re: [PATCHES] configure.in / xml / quoting trouble

2007-06-29 Thread Patrick Welche
On Thu, Jun 28, 2007 at 03:41:57PM -0400, Andrew Dunstan wrote: > Should a library we are using really be able to set the rpath for us? Are > there any other libraries that do that? After further thought, I should use the libxml2.la which libxml does install by default - libtool knows what the fl

Re: [PATCHES] WIP CSV logs

2007-06-29 Thread Andrew Dunstan
Andrew Dunstan wrote: Andrew Dunstan wrote: Here is a WIP patch of the CSV logs work brought up to date with CVS HEAD. One large change I made was to multiplex the selects on the pipes - previously it waited on one then the other - this seems almost to defeat the purpose of using select

Re: [PATCHES] WIP CSV logs

2007-06-29 Thread Dave Page
Andrew Dunstan wrote: > > Further update attached. Includes some code cleanup, and now sets up a > session-id for all processes, including postmaster, syslogger etc, so we > can make a primary key on the log table of (session_id, line_number). > > TODOs: fix on Windows, docs. I'm not going to be

Re: [PATCHES] configure.in / xml / quoting trouble

2007-06-29 Thread Tom Lane
Patrick Welche <[EMAIL PROTECTED]> writes: > The second part is a shell quoting problem. As the printf is inside > single quotes, the double quotes don't need to be escaped. My awk > received the backslashes and complained. I've applied this part. Turned out there was a second bug in the same are

Re: [PATCHES] configure.in / xml / quoting trouble

2007-06-29 Thread Tom Lane
Patrick Welche <[EMAIL PROTECTED]> writes: > On Thu, Jun 28, 2007 at 04:16:37PM -0400, Tom Lane wrote: >> What exactly does xml2-config --libs produce on your machine? > -Wl,-R/usr/local/lib -L/usr/local/lib -lxml2 -lz -lpthread -lm > but because I added the -R - it isn't the default as distribut

Re: [PATCHES] Cancel autovacuum conflicting with DROP TABLE

2007-06-29 Thread Alvaro Herrera
ITAGAKI Takahiro wrote: > > Alvaro Herrera <[EMAIL PROTECTED]> wrote: > > > 1. changing SIGINT so that it cancels the current table instead of > > shutting down the entire worker. I applied this part of the patch, thanks. In passing I noticed that apparently we are leaking memory, because the v

Re: [PATCHES] SPI-header-files safe for C++-compiler

2007-06-29 Thread Neil Conway
On Thu, 2007-06-28 at 12:08 +0200, Jacob Rief wrote: > If there is any chance to get this patch applied, I will of course regenerate > it out of the HEAD-revision of the CVS repository. I don't see a reason to reject the patch. All the arguments about why using C++ in the backend is ill-advised ar

[PATCHES] Checkpoint logging, revised patch

2007-06-29 Thread Heikki Linnakangas
Here's a reworked version Greg Smith's patch for logging checkpoints. It adds a GUC variable, log_checkpoints, along the lines of log_connections and log_autovacuum. Enabling it causes two lines to be printed to the system log per checkpoint, like this: LOG: checkpoint starting LOG: checkpoi

Re: [PATCHES] SPI-header-files safe for C++-compiler

2007-06-29 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > I don't see a reason to reject the patch. All the arguments about why > using C++ in the backend is ill-advised are well-taken, but the patch > does *not* require "making a real commitment to making C++ usable as a > backend extension language", it just obv

[PATCHES] Warm standby patch

2007-06-29 Thread Kevin Grittner
I'm submitting this patch in attempt to clarify some issues with the warm standby documentation which caused some confusion in our organization and which have been recently discussed on the admin list. -Kevin Index: backup.sgml ===

[PATCHES] Warm standby patch

2007-06-29 Thread Kevin Grittner
I'm submitting this patch in attempt to clarify some issues with the warm standby documentation which caused some confusion in our organization and which have been recently discussed on the admin list. I apologize for posting twice, but I noticed that my pseudo-code was unnecessarily long and comp

Re: [PATCHES] Checkpoint logging, revised patch

2007-06-29 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > One thing that's missing, that I originally hoped to achieve with this, > is logging the cause of a checkpoint. Doing that would have required > either sprinkling elogs to all callers of RequestCheckpoint, or adding a > "reason" parameter to it an

Re: [PATCHES] Checkpoint logging, revised patch

2007-06-29 Thread Greg Smith
On Fri, 29 Jun 2007, Heikki Linnakangas wrote: LOG: checkpoint complete; buffers written=5869 (35.8%); write=2.081 s, sync=4.851 s, total=7.066 s My original patch converted the buffers written to MB. Easier to estimate MB/s by eye; I really came to hate multiplying by 8K. And people who hav