Re: [PATCHES] V0.1 patch for TODO Item: SQL-language reference parameters by name.

2007-11-02 Thread Andrew Dunstan
Gevik Babakhani wrote: Hello all, Hereby an alpha version regarding the: TODO Item: SQL-language reference parameters by name. I am sending this patch to check if I am on the right track. So please take a look at this if possible. Step 1: don't use c++ style comments like this:

Re: [PATCHES] V0.1 patch for TODO Item: SQL-language reference parameters by name.

2007-11-02 Thread Gevik Babakhani
Noted. Thank you. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Andrew Dunstan Sent: Friday, November 02, 2007 4:19 PM To: Gevik Babakhani Cc: pgsql-patches@postgresql.org Subject: Re: [PATCHES] V0.1 patch for TODO Item: SQL-language reference parameters

Re: [PATCHES] krb_match_realm

2007-11-02 Thread Magnus Hagander
Henry B. Hotz wrote: > > On Nov 1, 2007, at 1:40 PM, Magnus Hagander wrote: > >> Henry B. Hotz wrote: >>> Thank you very much. This helps, but I'm still evaluating how much. >>> >>> I *can* point at one problem though: you do a strchr(gbuf.value, '@') >>> and then error out if there isn't a Ker

[PATCHES] V0.1 patch for TODO Item: SQL-language reference parameters by name.

2007-11-02 Thread Gevik Babakhani
Hello all, Hereby an alpha version regarding the: TODO Item: SQL-language reference parameters by name. I am sending this patch to check if I am on the right track. So please take a look at this if possible. What does this patch do? As discussed in thread: http://archives.postgres

Re: [PATCHES] V0.1 patch for TODO Item: SQL-language reference parameters by name.

2007-11-02 Thread Tom Lane
"Gevik Babakhani" <[EMAIL PROTECTED]> writes: > I am sending this patch to check if I am on the right track. > So please take a look at this if possible. You seem not to have understood my recommendation to use a callback function. This patch might work nicely for SQL functions but there will be

Re: [PATCHES] V0.1 patch for TODO Item: SQL-language reference parameters by name.

2007-11-02 Thread Pavel Stehule
> Hello all, > > > > Hereby an alpha version regarding the: > > TODO Item: SQL-language reference parameters by name. > > what about name's collision? Maybe is better use some prefix, like $ or :. Without it we only propagate one problem from plpgsql to others languages. It can be more wide used:

Re: [PATCHES] V0.1 patch for TODO Item: SQL-language reference parameters by name.

2007-11-02 Thread Tom Lane
"Gevik Babakhani" <[EMAIL PROTECTED]> writes: >> what about name's collision? Maybe is better use some prefix, >> like $ or :. Without it we only propagate one problem from >> plpgsql to others languages. > Please explain. > Perhaps I am wrong, but plpgsql handles arsgument names before it > pas

Re: [PATCHES] V0.1 patch for TODO Item: SQL-language reference parameters by name.

2007-11-02 Thread Pavel Stehule
On 02/11/2007, Gevik Babakhani <[EMAIL PROTECTED]> wrote: > > Hi, > > > what about name's collision? Maybe is better use some prefix, > > like $ or :. Without it we only propagate one problem from > > plpgsql to others languages. > > > Please explain. > > Perhaps I am wrong, but plpgsql handles ars

Re: [PATCHES] V0.1 patch for TODO Item: SQL-language reference parameters by name.

2007-11-02 Thread Gevik Babakhani
Hi, > what about name's collision? Maybe is better use some prefix, > like $ or :. Without it we only propagate one problem from > plpgsql to others languages. > Please explain. Perhaps I am wrong, but plpgsql handles arsgument names before it passes the query to be executed. Please see: p

Re: [PATCHES] krb_match_realm

2007-11-02 Thread Henry B. Hotz
On Nov 1, 2007, at 6:33 AM, Tom Lane wrote: Magnus Hagander <[EMAIL PROTECTED]> writes: Tom Lane wrote: Also the elog message texts need a bit of copy-editing. Probably ;-) Got any specific hints, so I don't have to go through the iteration twice? The one that caught my eye was

Re: [PATCHES] krb_match_realm

2007-11-02 Thread Henry B. Hotz
On Nov 2, 2007, at 8:38 AM, Magnus Hagander wrote: Henry B. Hotz wrote: On Nov 1, 2007, at 1:40 PM, Magnus Hagander wrote: Henry B. Hotz wrote: Thank you very much. This helps, but I'm still evaluating how much. I *can* point at one problem though: you do a strchr (gbuf.value, '@') a

Re: [PATCHES] krb_match_realm

2007-11-02 Thread Magnus Hagander
Henry B. Hotz wrote: > > On Nov 1, 2007, at 6:33 AM, Tom Lane wrote: > >> Magnus Hagander <[EMAIL PROTECTED]> writes: >>> Tom Lane wrote: Also the elog message texts need a bit of copy-editing. >> >>> Probably ;-) Got any specific hints, so I don't have to go through the >>> iteration twice?