Re: [PATCHES] lc_time and localized dates

2008-02-28 Thread Zdeněk Kotala
Peter Eisentraut napsal(a): Am Dienstag, 26. Februar 2008 schrieb Zdenek Kotala: But how you handle situation when you have multi language application which needs correct output for all languages? You cannot use any of the pattern because it will be wrong for some group of languages. T

Re: [PATCHES] DTrace probe patch for OS X Leopard

2008-02-28 Thread Robert Lor
Peter, Robert Lor wrote: Peter Eisentraut wrote: I have reworked your build rules so they look more like the idioms that we already use for other similar cases. This should fix the troubles you describe and others. There are a couple of problems with your updated patch: Based on your patc

Re: [PATCHES] DTrace probe patch for OS X Leopard

2008-02-28 Thread Peter Eisentraut
Robert Lor wrote: > dtrace call in src/Makefile is to generate probes.h before any file is > compiled so it can be used in c.h to avoid "probes.h not found" error. > The dtrace call in src/backend/Makefile is only needed for Solaris. Is c.h the right place to include this? The probes are only in

Re: [PATCHES] DTrace probe patch for OS X Leopard

2008-02-28 Thread Robert Lor
Peter Eisentraut wrote: Is c.h the right place to include this? The probes are only in the backend code, so perhaps postgres.h would be more appropriate. Or just include it in the .c files that need it, of which there are only 3. I think putting probes.h in c.h is the right place. It's true

[PATCHES] tuplestore_putvalues()

2008-02-28 Thread Neil Conway
Attached is a patch that allows an array of Datums + nulls to be inserted into a tuplestore without first creating a HeapTuple, per recent suggestion on -hackers. This avoids making an unnecessary copy. There isn't a really analogous optimization to be applied to tuplesort: it takes either a TTS, a

Re: [PATCHES] SRF memory leaks

2008-02-28 Thread Neil Conway
On Wed, 2008-02-27 at 10:54 -0800, Neil Conway wrote: > Barring any objections, I'll apply this to HEAD and back branches > tonight or tomorrow. Applied to HEAD, REL8_3_STABLE, and REL8_2_STABLE. (I can backpatch further if anyone feels strongly about it.) -Neil ---(end

[PATCHES] Logging conflicted queries on deadlocks

2008-02-28 Thread ITAGAKI Takahiro
Here is a patch to log conflicted queries on deadlocks. Queries are dumped at CONTEXT in the same sorting order as DETAIL messages. Those queries are picked from pg_stat_get_backend_activity, as same as pg_stat_activity, so that users cannot see other user's queries. (It might be better to log all

Re: [PATCHES] Fix for initdb failures on Vista

2008-02-28 Thread Andrew Dunstan
Dave Page wrote: The attached patch fixes problems reported primarily on Vista, but also on some Windows 2003 and XP installations in which initdb reports that it cannot find postgres.exe. This occurs because of security-related changes implemented in Windows Vista and recent patches on older

Re: [PATCHES] DTrace probe patch for OS X Leopard

2008-02-28 Thread Tom Lane
Robert Lor <[EMAIL PROTECTED]> writes: > Peter Eisentraut wrote: >> Is c.h the right place to include this? The probes are only in the backend >> code, so perhaps postgres.h would be more appropriate. Or just include it >> in >> the .c files that need it, of which there are only 3. >> > I thi

Re: [PATCHES] tuplestore_putvalues()

2008-02-28 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Attached is a patch that allows an array of Datums + nulls to be > inserted into a tuplestore without first creating a HeapTuple, per > recent suggestion on -hackers. This avoids making an unnecessary copy. A small thought here: we were jousting recently o

Re: [PATCHES] DTrace probe patch for OS X Leopard

2008-02-28 Thread Peter Eisentraut
Robert Lor wrote: > Please find the patch attached per this thread > http://archives.postgresql.org/pgsql-hackers/2008-02/msg00912.php Another thing that is concerning me about this new approach is the way the probes are named. For example, we'd now have a call POSTGRESQL_LWLOCK_ACQUIRE() in t