Re: [PATCHES] fixing bug in combocid.c

2008-09-01 Thread Heikki Linnakangas
Karl Schnaitter wrote: This patch is for a bug in backend/utils/time/combocid.c. In HeapTupleHeaderAdjustCmax, the code makes the incorrect assumption that the raw command id corresponds to cmin, when the raw command id can in fact be a combo cid. It needs to be fixed to call HeapTupleHeaderG

Re: [PATCHES] WIP Join Removal

2008-09-01 Thread Heikki Linnakangas
Simon Riggs wrote: Patch works, but there's a bit I haven't finished yet - checking unique indexes. Did plan invalidation make it safe to rely on the presence of a unique index for planning decisions? Couldn't we also do join removal for inner joins, when there's a foreign key reference tha